[tests] Fix Xamarin.Android-Tests solution#12008
Closed
simonrozsival wants to merge 1 commit into
Closed
Conversation
Update Xamarin.Android-Tests.sln to reference current .NET test projects and remove stale legacy Mono test metadata. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Xamarin.Android-Tests.sln solution and related references to align with the current .NET-based test/sample projects, while removing legacy/stale artifacts (old solution entries, IVT targets, and APK-size baselines) and refreshing documentation/metadata accordingly.
Changes:
- Refreshed
Xamarin.Android-Tests.slnproject/folder structure and replaced legacy test/sample entries with current.NETproject references. - Updated remaining hard-coded assembly/package references from
Mono.Android-Tests/Mono.Android_TeststoMono.Android.NET-Tests/Mono.Android.NET_Tests. - Removed obsolete APK size baseline CSVs and updated docs/TPN skill metadata for removed legacy artifacts.
Show a summary per file
| File | Description |
|---|---|
| Xamarin.Android-Tests.sln | Repoints solution to current projects; removes legacy entries; reorganizes solution folders. |
| tests/Mono.Android-Tests/Mono.Android-Tests/Resources/layout/FragmentFixup.axml | Updates fragment assembly references to Mono.Android.NET-Tests. |
| tests/apk-sizes-reference/TestResult-Mono.Android_TestsMultiDex-values-Release.csv | Removes obsolete APK-size baseline CSV. |
| tests/apk-sizes-reference/TestResult-Mono.Android_TestsMultiDex-values-Debug.csv | Removes obsolete APK-size baseline CSV. |
| tests/apk-sizes-reference/TestResult-Mono.Android_Tests-values-Release.csv | Removes obsolete APK-size baseline CSV. |
| tests/apk-sizes-reference/TestResult-Mono.Android_Tests-values-Debug.csv | Removes obsolete APK-size baseline CSV. |
| src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/Tasks/GetDependenciesTests.cs | Updates test manifest package name to Mono.Android.NET_Tests. |
| src/Mono.Android/Properties/AssemblyInfo.cs.in | Removes stale InternalsVisibleTo entries for legacy test assemblies. |
| Documentation/workflow/UnitTests.md | Updates description of how Layout CodeBehind is tested now. |
| Documentation/workflow/DevelopmentTips.md | Updates example package names/paths to Mono.Android.NET_Tests and new csproj path. |
| Documentation/guides/vscode-support.md | Updates VS Code task default/options to the .DotNet HelloWorld project. |
| Documentation/guides/profiling.md | Updates example project paths to .DotNet HelloWorld/HelloLibrary. |
| build-tools/Xamarin.Android.Tools.BootstrapTasks/Xamarin.Android.Tools.BootstrapTasks/RenameTestCases.cs | Updates comment examples to current test suite naming. |
| .github/skills/update-tpn/SKILL.md | Removes obsolete NUnitLite TPN entry reference. |
Copilot's findings
- Files reviewed: 14/14 changed files
- Comments generated: 2
Comment on lines
+36
to
39
| Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "HelloWorld", "HelloWorld", "{2633B698-A9AF-DF75-F94C-9021C604CA0C}" | ||
| EndProject | ||
| Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "timing", "build-tools\timing\timing.csproj", "{37CAA28C-40BE-4253-BA68-CC5D7316A617}" | ||
| Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "HelloWorld", "HelloWorld", "{00F1FAFB-D484-5C99-D022-F523885E2C79}" | ||
| EndProject |
| Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "StartupHook", "tests\StartupHook\StartupHook.csproj", "{3220BC41-7332-49A7-9286-5131477808EF}" | ||
| Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Java.Interop-Tests.NET", "tests\Mono.Android-Tests\Java.Interop-Tests\Java.Interop-Tests.NET.csproj", "{83E25890-BFC5-494A-BFF7-C3021C4272AF}" | ||
| EndProject | ||
| Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Mono.Android-Tests", "Mono.Android-Tests", "{5569B99A-9837-0E0F-C6F1-1926591449D0}" |
Member
Author
|
Replaced by #12009 from the dotnet/android branch. |
Comment on lines
+1
to
3
| | ||
| Microsoft Visual Studio Solution File, Format Version 12.00 | ||
| # Visual Studio Version 16 |
Member
There was a problem hiding this comment.
Should we change this to slnx while we are at it? There is a command to convert it automatically dotnet sln something something.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Xamarin.Android-Tests.slnto reference current.NETtest/sample projectsTesting
dotnet sln Xamarin.Android-Tests.sln listgit diff --checkdotnet build Xamarin.Android-Tests.sln -c Debug --no-restore /v:minimal; stale missing-project and CodeBehind placeholder failures are gone, remaining failures require prepared local SDK/restored assets