Skip to content

Remove logcat-parse#12028

Merged
simonrozsival merged 1 commit into
dotnet:mainfrom
simonrozsival:dev/simonrozsival/delete-logcat-parse
Jul 9, 2026
Merged

Remove logcat-parse#12028
simonrozsival merged 1 commit into
dotnet:mainfrom
simonrozsival:dev/simonrozsival/delete-logcat-parse

Conversation

@simonrozsival

@simonrozsival simonrozsival commented Jul 9, 2026

Copy link
Copy Markdown
Member

Goal

Remove the obsolete logcat-parse diagnostic tool from Java.Interop and dotnet/android packaging.

Motivation

logcat-parse is not part of the Android app runtime or normal app build path, but keeping it in Java.Interop.sln means CI restores and builds it during Java.Interop preparation. It depends on Mono.Terminal, and PR #12025 hit a red CI lane when prepare java.interop Release timed out restoring that package from the Azure DevOps feed:

NU1301: Failed to retrieve information about 'Mono.Terminal'
The HTTP request ... has timed out after 100000ms.

Removing the unused tool removes that restore dependency and the associated CI flake surface.

Summary

  • delete external/Java.Interop/tools/logcat-parse
  • delete external/Java.Interop/tests/logcat-parse-Tests
  • remove logcat-parse projects from Java.Interop.sln and Xamarin.Android.sln
  • remove the Java.Interop CI test entry for logcat-parse-Tests
  • remove Mono.Terminal and Mono.CSharp package-version pins that were only used by logcat-parse
  • stop packaging logcat-parse.exe, logcat-parse.pdb, and Mono.CSharp.dll in legacy installers
  • update docs and test catalog references

Validation

  • git diff --check
  • git grep -n "logcat-parse\|LogcatParse\|Mono.Terminal\|Mono.CSharp" -- . ':!bin/**' ':!obj/**' returned no matches
  • dotnet sln Xamarin.Android.sln list contains no logcat-parse project
  • dotnet sln external/Java.Interop/Java.Interop.sln list contains no logcat-parse project

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@simonrozsival simonrozsival marked this pull request as ready for review July 9, 2026 10:33
Copilot AI review requested due to automatic review settings July 9, 2026 10:33

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the obsolete logcat-parse diagnostic tool (and its unit tests) from Java.Interop and the broader dotnet/android packaging/build surface to eliminate an unnecessary restore/build dependency and reduce CI flakiness.

Changes:

  • Deletes external/Java.Interop/tools/logcat-parse and external/Java.Interop/tests/logcat-parse-Tests.
  • Removes the projects from Java.Interop.sln and Xamarin.Android.sln, and drops the CI test lane for logcat-parse-Tests.
  • Cleans up related packaging/docs/config references, including legacy installer payload and package-version pins only used by logcat-parse.
Show a summary per file
File Description
Xamarin.Android.sln Removes logcat-parse project and build configuration entries from the main solution.
external/Java.Interop/Java.Interop.sln Removes logcat-parse and logcat-parse-Tests projects and their configuration/nesting entries.
external/Java.Interop/Directory.Build.targets Removes Mono.CSharp and Mono.Terminal package version pins that were only needed by logcat-parse.
external/Java.Interop/build-tools/automation/templates/core-tests.yaml Removes the CI dotnet test invocation for logcat-parse-Tests.
external/Java.Interop/.vscode/settings.json Removes the LogcatParse-Tests.dll entry from the VS Code NUnit Explorer module list.
external/Java.Interop/Documentation/BuildConfiguration.md Updates documentation to no longer mention logcat-parse under utility outputs.
Documentation/guides/internals/debug-jni-objrefs.md Removes logcat-parse guidance and updates troubleshooting text accordingly.
build-tools/installers/create-installers.targets Stops packaging logcat-parse.exe/.pdb and Mono.CSharp.dll into legacy installers.
.github/skills/tests/references/test-catalog.md Removes logcat-parse-Tests from the test catalog references.
external/Java.Interop/tools/logcat-parse/repl.cs Deletes tool source (REPL support) as part of removing logcat-parse.
external/Java.Interop/tools/logcat-parse/Program.cs Deletes tool entrypoint as part of removing logcat-parse.
external/Java.Interop/tools/logcat-parse/PeerInfo.cs Deletes tool implementation types as part of removing logcat-parse.
external/Java.Interop/tools/logcat-parse/Grefs.cs Deletes tool parsing logic as part of removing logcat-parse.
external/Java.Interop/tools/logcat-parse/GrefParseOptions.cs Deletes tool options enum as part of removing logcat-parse.
external/Java.Interop/tools/logcat-parse/logcat-parse.targets Deletes tool build target as part of removing logcat-parse.
external/Java.Interop/tools/logcat-parse/logcat-parse.csproj Deletes tool project file as part of removing logcat-parse.
external/Java.Interop/tests/logcat-parse-Tests/logcat-parse-Tests.csproj Deletes the unit test project for logcat-parse.
external/Java.Interop/tests/logcat-parse-Tests/JniHandleInfoTests.cs Deletes logcat-parse unit tests.
external/Java.Interop/tests/logcat-parse-Tests/GrefsTest.cs Deletes logcat-parse unit tests.
external/Java.Interop/tests/logcat-parse-Tests/Resources/timestamp-ag-rg.txt Deletes logcat-parse test resource input.
external/Java.Interop/tests/logcat-parse-Tests/Resources/stdout-ag-rg.txt Deletes logcat-parse test resource input.
external/Java.Interop/tests/logcat-parse-Tests/Resources/stdio-repeated-handles.txt Deletes logcat-parse test resource input.
external/Java.Interop/tests/logcat-parse-Tests/Resources/stdio-JavaList.txt Deletes logcat-parse test resource input.
external/Java.Interop/tests/logcat-parse-Tests/Resources/stdio-Finalized-threads.txt Deletes logcat-parse test resource input.
external/Java.Interop/tests/logcat-parse-Tests/Resources/stdio-ag-rg.txt Deletes logcat-parse test resource input.
external/Java.Interop/tests/logcat-parse-Tests/Resources/logcat-resurrection.txt Deletes logcat-parse test resource input.
external/Java.Interop/tests/logcat-parse-Tests/Resources/logcat-Invoker-java_class_ref.txt Deletes logcat-parse test resource input.
external/Java.Interop/tests/logcat-parse-Tests/Resources/logcat-gwd.txt Deletes logcat-parse test resource input.
external/Java.Interop/tests/logcat-parse-Tests/Resources/logcat-get_class_ref.txt Deletes logcat-parse test resource input.
external/Java.Interop/tests/logcat-parse-Tests/Resources/logcat-disposed.txt Deletes logcat-parse test resource input.
external/Java.Interop/tests/logcat-parse-Tests/Resources/logcat-alias.txt Deletes logcat-parse test resource input.
external/Java.Interop/tests/logcat-parse-Tests/Resources/logcat-ag-rg.txt Deletes logcat-parse test resource input.

Copilot's findings

  • Files reviewed: 32/32 changed files
  • Comments generated: 0

@simonrozsival simonrozsival enabled auto-merge (squash) July 9, 2026 21:13
@simonrozsival simonrozsival merged commit 0b15bed into dotnet:main Jul 9, 2026
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants