[tests] Use dotnet-public for CI package resolution - #12198
Merged
Conversation
Route test package downloads and CI tool installation through the dnceng dotnet-public Azure Artifacts feed. Remove public NuGet overrides from generated test configurations. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 275239ae-25dd-465c-baca-77875b6b4b0f
Rely on the repository NuGet.config for the boots tool source and retain the informational NuGet package link in the device test comment. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 275239ae-25dd-465c-baca-77875b6b4b0f
Contributor
There was a problem hiding this comment.
Pull request overview
Routes test/CI package resolution away from public NuGet endpoints and through the dnceng dotnet-public Azure Artifacts feed by relying on the repository NuGet.config and updating direct .nupkg downloads.
Changes:
- Removed
ExtraNuGetConfigSourcesoverrides pointing atapi.nuget.orgfrom generated test projects. - Updated
FilterAssembliesTestsdirect package downloads to use thedotnet-publicV3flat2package base address. - Updated the API docs pipeline to install the
bootstool without explicitly adding nuget.org as a source.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/MSBuildDeviceIntegration/Tests/InstallAndRunTests.cs | Removes nuget.org override for a generated device-integration test project. |
| src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/Tasks/FilterAssembliesTests.cs | Switches direct .nupkg downloads from nuget.org to dotnet-public flat-container URLs. |
| src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/BuildTest.cs | Removes nuget.org override so restores use the repo NuGet.config feeds only. |
| build-tools/automation/azure-pipelines-apidocs.yaml | Removes --add-source nuget.org from dotnet tool update so it uses repo feeds after NuGetAuthenticate. |
Comments suppressed due to low confidence (1)
tests/MSBuildDeviceIntegration/Tests/InstallAndRunTests.cs:2532
- This test no longer adds nuget.org as an extra source, so package restore relies entirely on the repo NuGet.config feeds. Since this project references Xamarin.Google.Android.InstallReferrer 1.1.2.6 (and the PR description notes it is not mirrored to dotnet-public), the build will fail in network-isolated CI until that package is mirrored (or the test switches to a mirrored package/version).
var proj = new XamarinAndroidApplicationProject (packageName: PackageUtils.MakePackageName (runtime)) {
IsRelease = isRelease,
OtherBuildItems = {
new AndroidItem.TransformFile ("Transforms\\Metadata.xml") {
TextContent = () => $@"<metadata><attr path=""/api/package[@name='{gradleModule.PackageName}']"" name=""managedName"">Facebook</attr></metadata>",
},
Redth
approved these changes
Jul 21, 2026
Normalize NuGet flat-container version paths to lowercase and cover prerelease versions with a focused regression test. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 275239ae-25dd-465c-baca-77875b6b4b0f
jonathanpeppers
enabled auto-merge (squash)
July 21, 2026 22:04
rolfbjarne
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CFSClean reports network-isolation warnings when tests and CI tooling resolve packages directly from public NuGet endpoints. Route those package downloads through the existing dnceng
dotnet-publicAzure Artifacts feed and rely on the repositoryNuGet.configfor generated test projects and the API-docs tool installation.Direct
.nupkgtest downloads now use the feed's V3 package base address, while obsoleteExtraNuGetConfigSourcespublic overrides are removed. No fallback to nuget.org is retained.Xamarin.Google.Android.InstallReferrer1.1.2.6 is not currently mirrored todotnet-public;InstallAndRunTests.GradleFBProjwill require that package to be mirrored.Validation:
FilterAssembliesTests: 4 passedDotNetBuildproject using its generatedNuGet.configboots1.1.0.36 installation using the repositoryNuGet.configapi.nuget.org,www.nuget.org, andglobalcdn.nuget.org