[tests] Restore Java.Interop value manager coverage#12225
Merged
Conversation
Condition the value manager test exclusions on the runtime and typemap implementations that cannot execute them. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 4892bbc2-de90-442c-b18d-984fd1b165d2
Contributor
There was a problem hiding this comment.
Pull request overview
Restores Java.Interop value manager test coverage by conditionally excluding fixtures based on the runtime/typemap under test, instead of disabling them unconditionally after CoreCLR became the default.
Changes:
- Only compile
AndroidValueManagerContractTestswhenUseMonoRuntime=true(MonoVM), since CoreCLR/NativeAOT use different value manager implementations. - Only exclude
JniRuntime.JniValueManagerTestswhen using thetrimmabletypemap, whereReflectionJniValueManageris unsupported (#12221).
jonathanpeppers
added
the
ready-to-review
jonathanpeppers
enabled auto-merge (squash)
July 24, 2026 13:22
rolfbjarne
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
title and
description
should follow the
commit-messages.mdworkflow documentation, and in particular should include:Two Java.Interop test fixtures were unconditionally removed after CoreCLR became the default runtime, which also prevented tests compatible with CoreCLR from running.
Condition the removals on the implementations under test:
JniRuntimeJniValueManagerTestswith the default typemap, while retaining its focused trimmable exclusion becauseReflectionJniValueManageris unsupported there.AndroidValueManagerContractTestsonly for MonoVM because CoreCLR usesJavaMarshalValueManagerand the trimmable path usesTrimmableTypeMapValueManager.The trimmable limitation is tracked by #12221.
Validation: