Fix copy-paste bug: targetSdkVersion gated on MinSdkVersion in CreateDynamicFeatureManifest - #12251
Merged
Merged
Conversation
5 tasks
…teDynamicFeatureManifest Co-authored-by: jonathanpeppers <840039+jonathanpeppers@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix copy-paste bug in CreateDynamicFeatureManifest
Fix copy-paste bug: targetSdkVersion gated on MinSdkVersion in CreateDynamicFeatureManifest
Jul 28, 2026
jonathanpeppers
marked this pull request as ready for review
July 28, 2026 13:05
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a logic bug in CreateDynamicFeatureManifest.GenerateFeatureManifest where emitting the targetSdkVersion manifest attribute was incorrectly gated on MinSdkVersion (copy/paste mistake). This ensures targetSdkVersion is produced when provided and avoids ArgumentNullException when only MinSdkVersion is set.
Changes:
- Gate
uses-sdk/@android:targetSdkVersionemission onTargetSdkVersioninstead ofMinSdkVersion.
jonathanpeppers
approved these changes
Jul 28, 2026
jonathanpeppers
enabled auto-merge (squash)
July 28, 2026 17:04
rolfbjarne
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
CreateDynamicFeatureManifest.GenerateFeatureManifest, both theminSdkVersionandtargetSdkVersionattributes were guarded by!MinSdkVersion.IsNullOrEmpty()— a copy-paste error. This causedtargetSdkVersionto be silently omitted whenMinSdkVersionwas empty, and threwArgumentNullExceptionwhenMinSdkVersionwas set butTargetSdkVersionwas null.Change
Gate
targetSdkVersiononTargetSdkVersion: