Include asset locations in GetBuild Api calls - #6532
Merged
Conversation
premun
previously approved these changes
Jul 30, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Build retrieval paths to ensure asset location data is eagerly loaded when fetching a single build, so API consumers receive complete asset metadata (including locations) from GetBuild calls.
Changes:
- Updated
GetBuildqueries in PCS API versioned controllers toThenInclude(a => a.Locations)after including assets. - Aligned the BAR SQL client build query to include asset locations with a clearer lambda parameter name.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| src/ProductConstructionService/ProductConstructionService.Api/Api/v2020_02_20/Controllers/BuildsController.cs | Eager-loads Asset.Locations in GetBuild query for the 2020-02-20 API. |
| src/ProductConstructionService/ProductConstructionService.Api/Api/v2019_01_16/Controllers/BuildsController.cs | Eager-loads Asset.Locations in GetBuild query for the 2019-01-16 API. |
| src/ProductConstructionService/ProductConstructionService.Api/Api/v2018_07_16/Controllers/BuildsController.cs | Eager-loads Asset.Locations in GetBuild query for the 2018-07-16 API. |
| src/Maestro/Maestro.DataProviders/SqlBarClient.cs | Keeps asset-location include in BAR build query; updates lambda parameter naming for clarity. |
Comment on lines
95
to
99
| .Include(b => b.BuildChannels) | ||
| .ThenInclude(bc => bc.Channel) | ||
| .Include(b => b.Assets) | ||
| .ThenInclude(a => a.Locations) | ||
| .FirstOrDefaultAsync(); |
Comment on lines
87
to
91
| .Include(b => b.BuildChannels) | ||
| .ThenInclude(bc => bc.Channel) | ||
| .Include(b => b.Assets) | ||
| .ThenInclude(a => a.Locations) | ||
| .FirstOrDefaultAsync(); |
Member
There was a problem hiding this comment.
Also we should check why we have QuerySplittingBehavior set
Comment on lines
151
to
155
| .Include(b => b.BuildChannels) | ||
| .ThenInclude(bc => bc.Channel) | ||
| .Include(b => b.Assets) | ||
| .ThenInclude(a => a.Locations) | ||
| .FirstOrDefaultAsync(); |
Comment on lines
+89
to
+90
| .Include(b => b.Assets) | ||
| .ThenInclude(a => a.Locations) |
Comment on lines
+97
to
+98
| .Include(b => b.Assets) | ||
| .ThenInclude(a => a.Locations) |
This reverts commit d2c160e.
…Api/v2019_01_16/Controllers/BuildsController.cs Co-authored-by: Přemek Vysoký <premek.vysoky@microsoft.com>
premun
previously approved these changes
Jul 31, 2026
dkurepa
enabled auto-merge (squash)
July 31, 2026 12:28
premun
previously approved these changes
Aug 3, 2026
premun
left a comment
premun
left a comment
Member
There was a problem hiding this comment.
Any danger of some places now not having the assets when they had them before?
Member
Author
I don't think so, I went through it carefully, first without the default value, so I had it set explicitly everywhere, except the tests |
premun
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#6534
#6227