[main] Source code updates from dotnet/dotnet#17057
Conversation
No dependency updates to commit [[ commit created by automation ]]
|
Note VMR PRs included in this codeflow update:
💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance. |
|
Important While this PR was open, the source repository has received code changes from this repository (an opposite codeflow merged). You can continue with one of the following options:
💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance. |
2 similar comments
|
Important While this PR was open, the source repository has received code changes from this repository (an opposite codeflow merged). You can continue with one of the following options:
💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance. |
|
Important While this PR was open, the source repository has received code changes from this repository (an opposite codeflow merged). You can continue with one of the following options:
💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance. |
|
All failures are related to vswhere.exe @mmitche, is this a known infra issue? Would be nice to get this in before arcade->VMR flow (to avoid overwriting eng/common changes made in VMR the PR carries) |
|
FWIW, nativeaot package uses this standalone mechanism https://github.com/dotnet/runtime/blob/999ca22160f03e33dd970c93373dde5ad7fd1158/src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Windows.targets#L132-L159 it works with .NET engineering infra (those 10-15 components using PublishAot during VMR build across 4 repos..) as well as for Windows users out in the wild. So I think convergence with that infra would make sense. |
Unlikely to be an infra issue and more likely to be some intersection between VS and the SDK. |
|
Looking further, it looks like these are tests that @joeloff added. They proibably wont' work in Helix due to not having VS. Should we exclude them from PR runs? |
|
Important While this PR was open, the source repository has received code changes from this repository (an opposite codeflow merged). You can continue with one of the following options:
💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance. |
1 similar comment
|
Important While this PR was open, the source repository has received code changes from this repository (an opposite codeflow merged). You can continue with one of the following options:
💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance. |
|
@joeloff PTAL |
|
Important While this PR was open, the source repository has received code changes from this repository (an opposite codeflow merged). You can continue with one of the following options:
💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance. |
3 similar comments
|
Important While this PR was open, the source repository has received code changes from this repository (an opposite codeflow merged). You can continue with one of the following options:
💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance. |
|
Important While this PR was open, the source repository has received code changes from this repository (an opposite codeflow merged). You can continue with one of the following options:
💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance. |
|
Important While this PR was open, the source repository has received code changes from this repository (an opposite codeflow merged). You can continue with one of the following options:
💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance. |
Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
|
Important While this PR was open, the source repository has received code changes from this repository (an opposite codeflow merged). You can continue with one of the following options:
💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance. |
|
yeah, we should skip those tests if VS is not available. When would the tests run? They're not running as part of VMR. |
Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
|
@mmitche, is it possible to move the workload tests to an agent with VS on Windows. If we took toolset updates for SWIX, we wouldn't find issues until we insert into VS and if we need fixes, it might reset everything. I don't think it would happen that often, but wanted to call it out. I was told you're looking into adding support for running tests on agents instead of Helix. |
|
Looking at the current failures |
|
Looks like there's one remaining failure for workload sets. |
|
Important While this PR was open, the source repository has received code changes from this repository (an opposite codeflow merged). You can continue with one of the following options:
💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance. |
|
So the remaining test that is failing is because helix is missing a lot of files from the test asset folder. The logs shows there is only one package There should be 35. The binlog shows packages are being copied, so I don't know why all the other assets are present, but not these. |
|
Think I figured it out, it's case sensitive since we're building on Linux I think. |
Note
This is a codeflow update. It may contain both source code changes from
the VMR
as well as dependency updates. Learn more here.
This pull request brings the following source code changes
From https://github.com/dotnet/dotnet
Associated changes in source repos
Diff the source with this PR branch