Skip to content

[release/6.0] Remove artifact-feed PAT from asset publishing - #17244

Merged
missymessa merged 1 commit into
dotnet:release/6.0from
missymessa:missymessa/release-6-remove-artifact-feed-pat
Aug 4, 2026
Merged

[release/6.0] Remove artifact-feed PAT from asset publishing#17244
missymessa merged 1 commit into
dotnet:release/6.0from
missymessa:missymessa/release-6-remove-artifact-feed-pat

Conversation

@missymessa

@missymessa missymessa commented Aug 4, 2026

Copy link
Copy Markdown
Member

Summary

Removes the dn-bot-all-orgs-artifact-feeds-rw PAT from the release/6.0 asset-publishing templates.

  • removes the AzureDevOps-Artifact-Feeds-Pats variable-group link
  • removes enable-cross-org-publishing.ps1 -token $(dn-bot-all-orgs-artifact-feeds-rw)
  • retains NuGetAuthenticate@1 for the toolset restore
  • updates both the standard and official template copies

Evidence

The last successful release/6.0 official build that executed this job was dnceng/internal build 2885007. Its Publish Build Assets task restored Microsoft.DotNet.Arcade.Sdk 6.0.0-beta.25160.3 and ran PublishBuildAssets; the log contains no DevDiv package operation, 401, or 403. The branch's NuGet.config contains dnceng public feeds plus the public azure-public vs-buildservices feed, and no DevDiv source. The cross-org PAT injection is therefore not needed for this job; NuGetAuthenticate@1 remains in place.

The managed secret is intentionally retained in the vault manifest until the remaining branches/consumers are cleaned up.

Related: https://dnceng.visualstudio.com/internal/_workitems/edit/10145

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes cross-organization Azure Artifacts PAT injection from the release/6.0 “Publish Build Assets” job templates, relying on existing NuGetAuthenticate@1 for restore authentication while eliminating an unnecessary secret/variable-group dependency.

Changes:

  • Removed the AzureDevOps-Artifact-Feeds-Pats variable-group reference from the publish-build-assets job templates.
  • Removed the enable-cross-org-publishing.ps1 -token $(dn-bot-all-orgs-artifact-feeds-rw) step from both the standard and official templates.
  • Kept NuGetAuthenticate@1 in place for toolset restore authentication.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
eng/common/templates/job/publish-build-assets.yml Removes PAT variable group and cross-org feed auth script invocation from the publish assets job.
eng/common/templates-official/job/publish-build-assets.yml Mirrors the same PAT/script removal in the official template variant.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@missymessa
missymessa enabled auto-merge (squash) August 4, 2026 18:09
@missymessa

Copy link
Copy Markdown
Member Author

/azp run arcade-pr

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants