Skip to content

Reduce AssemblySearchPaths to minimal set of directories #428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 24, 2018
Merged

Reduce AssemblySearchPaths to minimal set of directories #428

merged 2 commits into from
Aug 24, 2018

Conversation

@tmat
Copy link
Member

@tmat tmat commented Aug 2, 2018

This setting is copied from Roslyn build.

@tmat
Reduce AssemblySearchPaths to minimal set of directories
efa61ed 
This setting is copied from Roslyn build.
rainersigwald
rainersigwald reviewed Aug 2, 2018
View reviewed changes
src/Microsoft.DotNet.Arcade.Sdk/tools/ProjectDefaults.props
<!--
This controls the places MSBuild will consult to resolve assembly references. This is
kept as minimal as possible to make our build reliable from machine to machine. Global
locations such as GAC, AssemblyFoldersEx, etc ... are deliberately removed from this

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@nguerrera nguerrera mentioned this pull request Aug 8, 2018
Closed
@tmat tmat mentioned this pull request Aug 15, 2018
Open
@tmat
Copy link
Member Author

tmat commented Aug 24, 2018

Added HintPath based on the above discussion.

@tmat tmat merged commit 8ac631c into master Aug 24, 2018
@tmat tmat deleted the dev/tmat/AssemblySearchPaths branch August 24, 2018 22:39
This was referenced Dec 13, 2018
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jaredpar jaredpar jaredpar left review comments

@jasonmalinowski jasonmalinowski jasonmalinowski left review comments

@rainersigwald rainersigwald rainersigwald left review comments

+2 more reviewers

@nguerrera nguerrera nguerrera left review comments

@weshaggard weshaggard weshaggard left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@tmat @nguerrera @jaredpar @jasonmalinowski @rainersigwald @weshaggard