Skip to content

Conversation

@javiercn
Copy link
Member

No description provided.

@javiercn javiercn requested review from a team and wtgodbe as code owners December 18, 2023 13:58
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Dec 18, 2023
@ghost
Copy link

ghost commented Dec 18, 2023

Hey @dotnet/aspnet-build, looks like this PR is something you want to take a look at.

@javiercn javiercn enabled auto-merge (squash) December 18, 2023 16:07
@javiercn javiercn merged commit 41d82c4 into main Dec 18, 2023
@javiercn javiercn deleted the dependencies/update-sdk-version branch December 18, 2023 16:20
@ghost ghost added this to the 9.0-preview1 milestone Dec 18, 2023
internal Task UpdateRootComponents(
RootComponentOperationBatch operationBatch,
ProtectedPrerenderComponentApplicationStore store,
IServerComponentDeserializer serverComponentDeserializer,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it related to the SDK update?

Copy link
Member Author

@javiercn javiercn Dec 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, the analyzer flagged it, and wasn't being used

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants