Skip to content

Avoid setting incompatible default value for StringValue sources #52895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 29, 2023
Merged

Avoid setting incompatible default value for StringValue sources #52895

merged 1 commit into from
Dec 29, 2023

Conversation

@captainsafia
Copy link
Member

@captainsafia captainsafia commented Dec 19, 2023

Closes #52315.

@ghost ghost added the area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions label Dec 19, 2023
@ghost
Copy link

ghost commented Dec 28, 2023

Looks like this PR hasn't been active for some time and the codebase could have been changed in the meantime.
To make sure no conflicting changes have occurred, please rerun validation before merging. You can do this by leaving an /azp run comment here (requires commit rights), or by simply closing and reopening.

@ghost ghost added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Dec 28, 2023
@captainsafia
Copy link
Member Author

captainsafia commented Dec 28, 2023

/azp run

@ghost ghost removed the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Dec 28, 2023
@captainsafia captainsafia added area-minimal Includes minimal APIs, endpoint filters, parameter binding, request delegate generator etc and removed area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions labels Dec 28, 2023
@azure-pipelines
Copy link

azure-pipelines bot commented Dec 28, 2023

Azure Pipelines successfully started running 3 pipeline(s).

@captainsafia captainsafia merged commit d81725e into main Dec 29, 2023
@captainsafia captainsafia deleted the safia/gh/52315 branch December 29, 2023 03:32
@ghost ghost added this to the 9.0-preview1 milestone Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@amcasey amcasey amcasey left review comments

@BrennanConroy BrennanConroy BrennanConroy approved these changes

@halter73 halter73 Awaiting requested review from halter73 halter73 is a code owner

Assignees

No one assigned

Labels

area-minimal Includes minimal APIs, endpoint filters, parameter binding, request delegate generator etc feature-rdg

Projects

None yet

Milestone

9.0-preview1

Development

Successfully merging this pull request may close these issues.

RDG does not support [FromQuery] for optional parameters

4 participants

@captainsafia @BrennanConroy @amcasey