Skip to content

Avoid setting incompatible default value for StringValue sources #52895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 29, 2023
Merged

Avoid setting incompatible default value for StringValue sources #52895

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Http/Http.Extensions/gen/StaticRouteHandlerModel/Emitters/EndpointParameterEmitter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ internal static void EmitQueryOrHeaderParameterPreparation(this EndpointParamete
}
else if (endpointParameter.IsOptional)
{
codeWriter.WriteLine($"var {endpointParameter.EmitTempArgument()} = {endpointParameter.EmitAssigningCodeResult()}.Count > 0 ? (string?){endpointParameter.EmitAssigningCodeResult()} : {endpointParameter.DefaultValue};");
codeWriter.WriteLine($"var {endpointParameter.EmitTempArgument()} = {endpointParameter.EmitAssigningCodeResult()}.Count > 0 ? (string?){endpointParameter.EmitAssigningCodeResult()} : null;");
}
else if (endpointParameter.IsStringValues)
{
Expand Down
14 changes: 14 additions & 0 deletions ....Extensions/test/RequestDelegateGenerator/RequestDelegateCreationTests.QueryParameters.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,20 @@ public async Task MapAction_MultipleStringParam_StringReturn()
await VerifyAgainstBaselineUsingFile(compilation);
}

[Fact]
public async Task MapAction_ExplicitParsableParameter_StringReturn()
{
var (results, compilation) = await RunGeneratorAsync("""
app.MapGet("/hello", ([FromQuery] int p1 = 10) => $"{p1}");
""");
var endpoint = GetEndpointFromCompilation(compilation);

var httpContext = CreateHttpContext();

await endpoint.RequestDelegate(httpContext);
await VerifyResponseBodyAsync(httpContext, "10");
}

public static object[][] MapAction_ExplicitQueryParam_NameTest_Data
{
get
Expand Down