Remove stale NETSDK1138 suppression (no more netcoreapp2.1 projects)#66098
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
github-actions
Bot
added
the
needs-area-label
Contributor
There was a problem hiding this comment.
Pull request overview
Removes an outdated build-warning suppression now that the repo no longer targets netcoreapp2.1, while keeping the existing suppression needed for remaining multi-targeting scenarios.
Changes:
- Drop
NETSDK1138from the globalNoWarnlist ineng/Workarounds.props. - Keep
CS8969suppression in place.
| @@ -25,9 +25,8 @@ | |||
| <UseSharedCompilation>true</UseSharedCompilation> | |||
| </PropertyGroup> | |||
|
|
|||
There was a problem hiding this comment.
The file header requests each workaround/suppression include a tracking issue reference, but the CS8969 suppression is now unannotated. Add a brief comment explaining why CS8969 is suppressed (and ideally link to the relevant issue) so it’s clear when this can be removed.
Suggested change
| <!-- Workaround for compiler warning CS8969; remove this suppression once the codebase builds clean without it. --> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NETSDK1138 warns about targeting unsupported frameworks. This was suppressing it for netcoreapp2.1, but no projects in the repo target netcoreapp2.1 anymore. CS8969 is retained as there are still 88 multi-targeting projects.