Skip to content

Remove stale NETSDK1138 suppression (no more netcoreapp2.1 projects) #66098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wtgodbe merged 1 commit into from
Apr 2, 2026
+1 −2
Merged

Remove stale NETSDK1138 suppression (no more netcoreapp2.1 projects) #66098

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions eng/Workarounds.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,8 @@
<UseSharedCompilation>true</UseSharedCompilation>
</PropertyGroup>

Copy link

Copilot AI Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file header requests each workaround/suppression include a tracking issue reference, but the CS8969 suppression is now unannotated. Add a brief comment explaining why CS8969 is suppressed (and ideally link to the relevant issue) so it’s clear when this can be removed.

Suggested change
<!-- Workaround for compiler warning CS8969; remove this suppression once the codebase builds clean without it. -->

Copilot uses AI. Check for mistakes.
<!-- Workaround continued use of netcoreapp2.1. -->
<PropertyGroup>
<NoWarn>$(NoWarn);NETSDK1138;CS8969</NoWarn>
<NoWarn>$(NoWarn);CS8969</NoWarn>
</PropertyGroup>

<!-- Workaround obsolete X509Certificate ctor: https://github.com/dotnet/docs/issues/41662 -->
Expand Down
Loading