fix(http2/3): add trailer headers timeout#66249
Merged
DeagleGross merged 6 commits intodotnet:mainfrom Apr 23, 2026
Merged
Conversation
DeagleGross
added
the
area-networking
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes HTTP/2 trailer header timeout handling in Kestrel so that fragmented trailer HEADERS blocks (missing END_HEADERS) correctly arm/enforce RequestHeadersTimeout, avoiding connections that can hang indefinitely waiting for a final CONTINUATION frame.
Changes:
- Arm
RequestHeadersTimeoutwhen receiving fragmented trailer HEADERS (noEND_HEADERS) and cancel it when the trailer header block completes. - Add functional tests covering trailer HEADERS timeout enforcement and cancellation scenarios.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/Servers/Kestrel/Core/src/Internal/Http2/Http2Connection.cs |
Arms/cancels RequestHeadersTimeout for fragmented trailer HEADERS/CONTINUATION sequences. |
src/Servers/Kestrel/test/InMemory.FunctionalTests/Http2/Http2TimeoutTests.cs |
Adds new HTTP/2 timeout tests specifically for fragmented trailer header blocks. |
halter73
approved these changes
Apr 14, 2026
Member
halter73
left a comment
halter73
left a comment
There was a problem hiding this comment.
I thought we already did this
…github.com/DeagleGross/aspnetcore into dmkorolev/sec/http2-headertrailers-timeout
…-headertrailers-timeout
DeagleGross
changed the title
This was referenced Apr 18, 2026
dotnet-policy-service
Bot
added
the
pending-ci-rerun
Member
|
I think the HTTP/3 changes look good too. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing handling of HTTP/2 trailer header timeouts in Kestrel by ensuring that fragmented trailer HEADERS frames (those missing END_HEADERS) correctly arm and enforce the
RequestHeadersTimeout, preventing connections from hanging indefinitely.same for http/3