Remove misplaced pure annotations#66778
Conversation
|
Thanks for your PR, @TheAlexLichter. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
There was a problem hiding this comment.
Pull request overview
Removes misplaced /*#__PURE__*/ annotations from private helper function declarations in the SignalR TypeScript client to avoid downstream bundler INVALID_ANNOTATION warnings, without changing helper behavior.
Changes:
- Removed
/*#__PURE__*/annotations and the associated eslint suppression fromgetOsNameandgetRuntimeVersionhelper declarations. - Kept the helper implementations and call sites unchanged.
7aef69e to
1b96b6e
Compare
pure annotations
pure annotationspure annotations
|
there is also a related issue: #55286 |
|
Some context #55496 (comment) Although, re-reading the webpack docs it looks like Looks like if we update webpack to 5.107.0+ we can use the |
This PR removes invalid
/*#__PURE__*/comments from private helper function.These annotations only apply to call/new expressions, so they are ignored in this position and can produce
INVALID_ANNOTATIONwarnings in downstream bundlers.Resolves #55286
See also rolldown/rolldown#9496