Use globalized type names in validations gen by Youssef1313 · Pull Request #67363 · dotnet/aspnetcore

Youssef1313 · 2026-06-22T09:29:03Z

It's always a good practice to use global:: in generated code to avoid any potential conflicts.

Copilot

Pull request overview

This PR updates the ValidationsGenerator source generator output to use global::-qualified type names in more places, reducing the chance that consumer-defined types or using aliases could cause name resolution conflicts in generated validation code. The accompanying generator test snapshots are updated to match the new emitted source.

Changes:

Global-qualify framework types in the generated InterceptsLocationAttribute declaration (e.g., AttributeUsageAttribute, System.Attribute).
Global-qualify generator-emitted validation helper types when constructing GeneratedValidatableTypeInfo, GeneratedValidatablePropertyInfo, and display-name helper instances.
Update verified snapshot baselines in generator tests to reflect the new generated output.

Reviewed changes

Copilot reviewed 41 out of 41 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
src/Validation/gen/Emitters/ValidationsGenerator.Emitter.cs	Emits `global::`-qualified type names in generated validation resolver code.
src/Validation/test/Microsoft.Extensions.Validation.GeneratorTests/snapshots/ValidationsGeneratorTests.ValidatesPropertiesWithJsonIgnoreWhenWritingConditions#ValidatableInfoResolver.g.verified.cs	Snapshot updated for `global::`-qualified generated type names.
src/Validation/test/Microsoft.Extensions.Validation.GeneratorTests/snapshots/ValidationsGeneratorTests.SkipsNonReadableAndStaticProperties#ValidatableInfoResolver.g.verified.cs	Snapshot updated for `global::`-qualified generated type names.
src/Validation/test/Microsoft.Extensions.Validation.GeneratorTests/snapshots/ValidationsGeneratorTests.SkipsIndexerPropertiesOnTypes#ValidatableInfoResolver.g.verified.cs	Snapshot updated for `global::`-qualified generated type names.
src/Validation/test/Microsoft.Extensions.Validation.GeneratorTests/snapshots/ValidationsGeneratorTests.SkipsClassesWithNonAccessibleTypes#ValidatableInfoResolver.g.verified.cs	Snapshot updated for `global::`-qualified generated type names.
src/Validation/test/Microsoft.Extensions.Validation.GeneratorTests/snapshots/ValidationsGeneratorTests.DoesNotEmitForExemptTypes#ValidatableInfoResolver.g.verified.cs	Snapshot updated for `global::`-qualified generated type names.
src/Validation/test/Microsoft.Extensions.Validation.GeneratorTests/snapshots/ValidationsGeneratorTests.DoesNotEmit_ForSkipValidationAttribute_OnRecordProperties#ValidatableInfoResolver.g.verified.cs	Snapshot updated for `global::`-qualified generated type names.
src/Validation/test/Microsoft.Extensions.Validation.GeneratorTests/snapshots/ValidationsGeneratorTests.DoesNotEmit_ForSkipValidationAttribute_OnEndpointParameters#ValidatableInfoResolver.g.verified.cs	Snapshot updated for `global::`-qualified generated type names.
src/Validation/test/Microsoft.Extensions.Validation.GeneratorTests/snapshots/ValidationsGeneratorTests.DoesNotEmit_ForSkipValidationAttribute_OnClassProperties#ValidatableInfoResolver.g.verified.cs	Snapshot updated for `global::`-qualified generated type names.
src/Validation/test/Microsoft.Extensions.Validation.GeneratorTests/snapshots/ValidationsGeneratorTests.CanValidateValidationAttributesOnClasses#ValidatableInfoResolver.g.verified.cs	Snapshot updated for `global::`-qualified generated type names.
src/Validation/test/Microsoft.Extensions.Validation.GeneratorTests/snapshots/ValidationsGeneratorTests.CanValidateTypeWithParsableProperties#ValidatableInfoResolver.g.verified.cs	Snapshot updated for `global::`-qualified generated type names.
src/Validation/test/Microsoft.Extensions.Validation.GeneratorTests/snapshots/ValidationsGeneratorTests.CanValidateRecursiveTypes#ValidatableInfoResolver.g.verified.cs	Snapshot updated for `global::`-qualified generated type names.
src/Validation/test/Microsoft.Extensions.Validation.GeneratorTests/snapshots/ValidationsGeneratorTests.CanValidateRecordTypesWithAttribute#ValidatableInfoResolver.g.verified.cs	Snapshot updated for `global::`-qualified generated type names.
src/Validation/test/Microsoft.Extensions.Validation.GeneratorTests/snapshots/ValidationsGeneratorTests.CanValidateRecordTypes#ValidatableInfoResolver.g.verified.cs	Snapshot updated for `global::`-qualified generated type names.
src/Validation/test/Microsoft.Extensions.Validation.GeneratorTests/snapshots/ValidationsGeneratorTests.CanValidateRecordStructTypes#ValidatableInfoResolver.g.verified.cs	Snapshot updated for `global::`-qualified generated type names.
src/Validation/test/Microsoft.Extensions.Validation.GeneratorTests/snapshots/ValidationsGeneratorTests.CanValidatePolymorphicTypes#ValidatableInfoResolver.g.verified.cs	Snapshot updated for `global::`-qualified generated type names.
src/Validation/test/Microsoft.Extensions.Validation.GeneratorTests/snapshots/ValidationsGeneratorTests.CanValidateParameters#ValidatableInfoResolver.g.verified.cs	Snapshot updated for `global::`-qualified generated type names.
src/Validation/test/Microsoft.Extensions.Validation.GeneratorTests/snapshots/ValidationsGeneratorTests.CanValidateMultipleNamespaces#ValidatableInfoResolver.g.verified.cs	Snapshot updated for `global::`-qualified generated type names.
src/Validation/test/Microsoft.Extensions.Validation.GeneratorTests/snapshots/ValidationsGeneratorTests.CanValidateIValidatableObject#ValidatableInfoResolver.g.verified.cs	Snapshot updated for `global::`-qualified generated type names.
src/Validation/test/Microsoft.Extensions.Validation.GeneratorTests/snapshots/ValidationsGeneratorTests.CanValidateIValidatableObject_WithoutPropertyValidations#ValidatableInfoResolver.g.verified.cs	Snapshot updated for `global::`-qualified generated type names.
src/Validation/test/Microsoft.Extensions.Validation.GeneratorTests/snapshots/ValidationsGeneratorTests.CanValidateComplexTypesWithJsonIgnore#ValidatableInfoResolver.g.verified.cs	Snapshot updated for `global::`-qualified generated type names.
src/Validation/test/Microsoft.Extensions.Validation.GeneratorTests/snapshots/ValidationsGeneratorTests.CanValidateComplexTypes#ValidatableInfoResolver.g.verified.cs	Snapshot updated for `global::`-qualified generated type names.
src/Validation/test/Microsoft.Extensions.Validation.GeneratorTests/snapshots/ValidationsGeneratorTests.CanValidateClassTypesWithAttribute#ValidatableInfoResolver.g.verified.cs	Snapshot updated for `global::`-qualified generated type names.
src/Validation/test/Microsoft.Extensions.Validation.GeneratorTests/snapshots/ValidationsGeneratorTests.CanUseBothFrameworkAndGeneratedValidatableTypeAttributes#ValidatableInfoResolver.g.verified.cs	Snapshot updated for `global::`-qualified generated type names.
src/Validation/test/Microsoft.Extensions.Validation.GeneratorTests/snapshots/ValidationsGeneratorTests.CanGenerateWhenAddValidationCalledMultipleTimes#ValidatableInfoResolver.g.verified.cs	Snapshot updated for `global::`-qualified generated type names.
src/Validation/test/Microsoft.Extensions.Validation.GeneratorTests/snapshots/ValidationsGeneratorTests.CanDiscoverGeneratedValidatableTypeAttribute#ValidatableInfoResolver.g.verified.cs	Snapshot updated for `global::`-qualified generated type names.
src/Validation/test/Microsoft.Extensions.Validation.GeneratorTests/snapshots/ValidationsGeneratorDisplayNameTests.TypeDisplayName_WithResourceType#ValidatableInfoResolver.g.verified.cs	Snapshot updated for `global::`-qualified display-name helper types.
src/Validation/test/Microsoft.Extensions.Validation.GeneratorTests/snapshots/ValidationsGeneratorDisplayNameTests.TypeDisplayName_WithNameOnly#ValidatableInfoResolver.g.verified.cs	Snapshot updated for `global::`-qualified display-name helper types.
src/Validation/test/Microsoft.Extensions.Validation.GeneratorTests/snapshots/ValidationsGeneratorDisplayNameTests.TypeDisplayName_WithDisplayNameAttribute#ValidatableInfoResolver.g.verified.cs	Snapshot updated for `global::`-qualified display-name helper types.
src/Validation/test/Microsoft.Extensions.Validation.GeneratorTests/snapshots/ValidationsGeneratorDisplayNameTests.RecordPropertyDisplayName_WithResourceType#ValidatableInfoResolver.g.verified.cs	Snapshot updated for `global::`-qualified display-name helper types.
src/Validation/test/Microsoft.Extensions.Validation.GeneratorTests/snapshots/ValidationsGeneratorDisplayNameTests.RecordPropertyDisplayName_WithNameOnly#ValidatableInfoResolver.g.verified.cs	Snapshot updated for `global::`-qualified display-name helper types.
src/Validation/test/Microsoft.Extensions.Validation.GeneratorTests/snapshots/ValidationsGeneratorDisplayNameTests.RecordPropertyDisplayName_LiteralOnConstructorParameter#ValidatableInfoResolver.g.verified.cs	Snapshot updated for `global::`-qualified display-name helper types.
src/Validation/test/Microsoft.Extensions.Validation.GeneratorTests/snapshots/ValidationsGeneratorDisplayNameTests.PropertyDisplayName_WithResourceType#ValidatableInfoResolver.g.verified.cs	Snapshot updated for `global::`-qualified display-name helper types.
src/Validation/test/Microsoft.Extensions.Validation.GeneratorTests/snapshots/ValidationsGeneratorDisplayNameTests.PropertyDisplayName_WithoutDisplayAttribute_UsesPropertyName#ValidatableInfoResolver.g.verified.cs	Snapshot updated for `global::`-qualified generated type names.
src/Validation/test/Microsoft.Extensions.Validation.GeneratorTests/snapshots/ValidationsGeneratorDisplayNameTests.PropertyDisplayName_WithNameOnly#ValidatableInfoResolver.g.verified.cs	Snapshot updated for `global::`-qualified display-name helper types.
src/Validation/test/Microsoft.Extensions.Validation.GeneratorTests/snapshots/ValidationsGeneratorDisplayNameTests.PropertyDisplayName_WithDisplayNameAttribute#ValidatableInfoResolver.g.verified.cs	Snapshot updated for `global::`-qualified display-name helper types.
src/Validation/test/Microsoft.Extensions.Validation.GeneratorTests/snapshots/ValidationsGeneratorDisplayNameTests.PropertyDisplayName_WithControlCharacters_EmitsValidLiteral#ValidatableInfoResolver.g.verified.cs	Snapshot updated for `global::`-qualified display-name helper types.
src/Validation/test/Microsoft.Extensions.Validation.GeneratorTests/snapshots/ValidationsGeneratorDisplayNameTests.PropertyDisplayName_DisplayAttributeTakesPrecedenceOverDisplayNameAttribute#ValidatableInfoResolver.g.verified.cs	Snapshot updated for `global::`-qualified display-name helper types.
src/Validation/test/Microsoft.Extensions.Validation.GeneratorTests/snapshots/ValidationsGeneratorDisplayNameTests.PropertyDisplayName_DisplayAttributeResourceTypeTakesPrecedenceOverDisplayNameAttribute#ValidatableInfoResolver.g.verified.cs	Snapshot updated for `global::`-qualified display-name helper types.
src/Validation/test/Microsoft.Extensions.Validation.GeneratorTests/snapshots/ValidationsGeneratorDisplayNameTests.ParameterDisplayName_WithResourceType#ValidatableInfoResolver.g.verified.cs	Snapshot updated for `global::`-qualified generated type names.
src/Validation/test/Microsoft.Extensions.Validation.GeneratorTests/snapshots/ValidationsGeneratorDisplayNameTests.ParameterDisplayName_WithNameOnly#ValidatableInfoResolver.g.verified.cs	Snapshot updated for `global::`-qualified generated type names.

    {{GeneratedCodeAttribute}}
-    [AttributeUsage(AttributeTargets.Method, AllowMultiple = true)]
-    file sealed class InterceptsLocationAttribute : System.Attribute
+    [global::System.AttributeUsage(AttributeTargets.Method, AllowMultiple = true)]
+    file sealed class InterceptsLocationAttribute : global::System.Attribute


Co-authored-by: Youssef1313 <31348972+Youssef1313@users.noreply.github.com>

rokonec

LGTM

Use globalized type names in validations gen

0ed12b9

Copilot AI review requested due to automatic review settings June 22, 2026 09:29

Copilot started reviewing on behalf of Youssef1313 June 22, 2026 09:29 View session

Youssef1313 requested a review from oroztocil June 22, 2026 09:30

Copilot AI reviewed Jun 22, 2026

View reviewed changes

Copilot started work on behalf of Youssef1313 June 22, 2026 09:35 View session

Qualify AttributeTargets in generated attribute usage

09d001b

Co-authored-by: Youssef1313 <31348972+Youssef1313@users.noreply.github.com>

Copilot finished work on behalf of Youssef1313 June 22, 2026 09:46

This was referenced Jun 22, 2026

[Known Build Error] TestServerTests.LongPollingWorks - ObjectDisposedException in OnDisconnectedAsync during shutdown #65702

Open

The Operation will be canceled. The next steps may not contain expected logs. dotnet/dnceng#3008

Open

rokonec approved these changes Jun 22, 2026

View reviewed changes

Youssef1313 enabled auto-merge (squash) June 22, 2026 14:17

Youssef1313 merged commit 579a905 into main Jun 22, 2026
25 checks passed

Youssef1313 deleted the dev/ygerges/globalized branch June 22, 2026 15:05

dotnet-maestro Bot mentioned this pull request Jun 23, 2026

[main] Source code updates from dotnet/aspnetcore dotnet/dotnet#7330

Merged

dotnet-milestone-bot Bot added this to the 11.0-preview6 milestone Jun 23, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Use globalized type names in validations gen#67363

Use globalized type names in validations gen#67363
Youssef1313 merged 2 commits into
mainfrom
dev/ygerges/globalized

Youssef1313 commented Jun 22, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

rokonec left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

Youssef1313 commented Jun 22, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

rokonec left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants