Merge endpoint metadata for dynamic endpoints.#67664
Open
cincuranet wants to merge 6 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses #66666 by preserving metadata configured on dynamic/fallback endpoints when they are resolved into page/controller endpoints (via CandidateSet.ExpandEndpoint). This ensures metadata like authorization on the dynamic route isn’t dropped during endpoint expansion.
Changes:
- Merge original dynamic endpoint metadata into resolved Razor Pages endpoints before expanding candidates.
- Merge original dynamic endpoint metadata into resolved MVC controller endpoints before expanding candidates.
- Add a shared
DynamicEndpointMetadataMergerhelper and expand test coverage for merged-metadata scenarios.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Mvc/Mvc.RazorPages/src/Infrastructure/DynamicPageEndpointMatcherPolicy.cs | Merges dynamic endpoint metadata into resolved page endpoints (compiled and runtime-compiled). |
| src/Mvc/Mvc.Core/src/Routing/DynamicControllerEndpointMatcherPolicy.cs | Merges dynamic endpoint metadata into resolved controller endpoints before expanding candidates. |
| src/Mvc/Mvc.Core/src/Routing/DynamicEndpointMetadataMerger.cs | Introduces helper to clone endpoints with combined metadata at correct precedence. |
| src/Mvc/Mvc.RazorPages/test/Infrastructure/DynamicPageEndpointMatcherPolicyTest.cs | Updates existing assertions (no longer reference-equality) and adds metadata-merge tests for pages. |
| src/Mvc/Mvc.Core/test/Routing/DynamicControllerEndpointMatcherPolicyTest.cs | Updates existing assertions and adds metadata-merge tests for controllers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #66666.