Stabilize DelegateTests.DelegateAfterReceiverRestart Quarantine test - #68131
Open
karmegams02 wants to merge 6 commits into
Open
Stabilize DelegateTests.DelegateAfterReceiverRestart Quarantine test#68131karmegams02 wants to merge 6 commits into
karmegams02 wants to merge 6 commits into
Conversation
-Recreate DelegationRule after receiver restart instead of using the stale/disposed rule to prevent HTTP 500 failures.
Contributor
|
Thanks for your PR, @karmegams02. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
Contributor
There was a problem hiding this comment.
Pull request overview
Stabilizes the DelegateAfterReceiverRestart HttpSys functional test by ensuring request delegation remains valid after the receiver server is restarted and re-attaches to the existing request queue.
Changes:
- Recreates the
DelegationRuleafter the receiver restart so delegation targets the reattached queue. - Removes the quarantine attribute from
DelegateAfterReceiverRestart.
…eceiver restart to prevent native handle leaks that contribute to test flakiness.
…pnetcore into 60141_testfailure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stabilize DelegateTests.DelegateAfterReceiverRestart
Description
This PR addresses failures in
Microsoft.AspNetCore.Server.HttpSys.FunctionalTests.DelegateTests.DelegateAfterReceiverRestart.The test could fail after the receiver server was restarted because request delegation continued using a previously created
DelegationRulethat was no longer valid. This resulted in delegated requests returning HTTP 500 responses instead of reaching the restarted receiver.To ensure delegation remains functional after a receiver restart, the test now recreates the
DelegationRuleonce the receiver has been restarted and reattached to the request queue.Validation / Investigation
DelegationRuleinstance was tied to the previous receiver attachment and became invalid once the receiver was stopped.DelegationRuleafter queue reattachment restores proper request delegation and allows the test to complete successfully.Changes
DelegationRuleafter the receiver restart.Fixes #60141.