Bump the JobMonitor - #68472
Conversation
.. to fix problems with re-runs
|
cc @Youssef1313 |
There was a problem hiding this comment.
Pull request overview
This PR updates the Helix Job Monitor tooling/dependency versions to address rerun issues, and extends the Helix job monitor pipeline template with a new option to control per-test output attachments.
Changes:
- Bumps
Microsoft.DotNet.Helix.JobMonitorto11.0.0-beta.26412.2and updates the repo-local .NET tool manifest accordingly. - Updates toolset dependency metadata in
eng/Version.Details.xml(includingMicrosoft.DotNet.Arcade.Sdk). - Adds a
testResultAttachmentModeparameter to the Helix job monitor pipeline template and forwards it to the tool.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| global.json | Minor formatting change; still pins Microsoft.DotNet.Arcade.Sdk in msbuild-sdks. |
| eng/Version.Details.xml | Updates dependency entries for Arcade SDK and Helix JobMonitor to newer versions/SHAs. |
| eng/Version.Details.props | Updates JobMonitor package version property; adds clearer grouping for Arcade-related alternate version properties. |
| eng/common/core-templates/job/helix-job-monitor.yml | Adds testResultAttachmentMode parameter and passes --test-result-attachment-mode to the tool. |
| .config/dotnet-tools.json | Bumps the microsoft.dotnet.helix.jobmonitor tool version to 11.0.0-beta.26412.2. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
| <Uri>https://github.com/dotnet/dotnet</Uri> | ||
| <Sha>64a29867c5c5c8e0babc9e31313cf3b6e50f0193</Sha> | ||
| <Dependency Name="Microsoft.DotNet.Helix.JobMonitor" Version="11.0.0-beta.26412.2"> | ||
| <Uri>https://github.com/dotnet/arcade</Uri> |
There was a problem hiding this comment.
Hmm, SDK sets this to VMR repo, while runtime uses Arcade.
Does the package effectively get published from both repos (Arcade and VMR)? 👀
There was a problem hiding this comment.
All package versions in https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-eng/nuget/v3/index.json appear to be published from dotnet/arcade and not VMR. So I guess this should be fixed in dotnet/sdk repo as well?
There was a problem hiding this comment.
It gets published from both Arcade and VMR. It should not matter much which one we use here.
The XML only says where the last package comes from.
Shortly, it will get overriden by the next VMR backflow but by then, I hope it will already contain the same code:
dotnet/dotnet#8263
| <Dependency Name="Microsoft.DotNet.Helix.JobMonitor" Version="11.0.0-beta.26412.2"> | ||
| <Uri>https://github.com/dotnet/arcade</Uri> |
There was a problem hiding this comment.
Should we also update Microsoft.DotNet.Arcade.Sdk to point to dotnet/arcade and not dotnet/dotnet?
There was a problem hiding this comment.
The XML only says where the package was built so it's fine like this
There was a problem hiding this comment.
@premun Does it affect how Darc finds the latest version to make the update?
Per the nuspec, it seems that Arcade.Sdk is published from dotnet/arcade:
Also, in Version.Details.props, the MicrosoftDotNetArcadeSdkVersion property moved under dotnet-arcade dependencies comment. So the Version.Details.xml is now mismatching.
There was a problem hiding this comment.
The package is only matched by name, so the next backflow from VMR will again turn everything to dotnet/dotnet.
But Arcade.Sdk is built in both VMR and Arcade atm.
Version.Details.props are just auto-generated to match the Version.Details.xml. It does not matter much how it's shuffled around.
So we should be good.
.. to fix problems with re-runs