Fix #1726 - allow FromAmong to be case-insensitive#2780
Merged
jonsequitur merged 2 commits intodotnet:mainfrom Apr 2, 2026
Merged
Fix #1726 - allow FromAmong to be case-insensitive#2780jonsequitur merged 2 commits intodotnet:mainfrom
FromAmong to be case-insensitive#2780jonsequitur merged 2 commits intodotnet:mainfrom
Conversation
jonsequitur
changed the title
FromAmong to be case-insensitive
jeffhandley
approved these changes
Apr 2, 2026
Member
jeffhandley
left a comment
jeffhandley
left a comment
There was a problem hiding this comment.
Look great to me. Just had a recommendation and a low-pri suggestion on the tests. The implementation is very straightforward for what is being achieved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a proposed fix for #1726. I would appreciate feedback or alternative ideas for the API.