Update Cli, CoreFx, CoreFx, CoreFx, CoreFx, CoreFx, CoreSetup, CoreSetup to preview2-008290, preview2-26303-02, preview2-26303-02, preview2-26303-02, preview2-26303-02, preview2-26303-02, preview2-26228-04, preview2-26228-04, respectively (master)#2142
Conversation
76bec76 to
64c68e3
Compare
64c68e3 to
11776e6
Compare
…tup to preview2-008290, preview2-26303-02, preview2-26303-02, preview2-26303-02, preview2-26303-02, preview2-26303-02, preview2-26228-04, preview2-26228-04, respectively
11776e6 to
4ea377b
Compare
|
cc @atsushikan, @pakrym, @davidfowl, @KrzysztofCwalina, @benaadams, @eerhardt - please review. We are grabbing the latest packages (< 2 hours old). Several tests are failing now, but the build failures have been resolved. Investigation pending. Most of the failures have to do with ReadOnlySequence: OR For example, the ReadOnlySequence constructor is throwing ArgumentOutOfRangeException exception now: var parser = new HttpParser();
for (int pivot = 26; pivot < requestText.Length; pivot++) {
var front = requestText.Substring(0, pivot);
var back = requestText.Substring(pivot);
var frontBytes = Encoding.ASCII.GetBytes(front);
var endBytes = Encoding.ASCII.GetBytes(back);
var (first, last) = BufferList.Create(frontBytes, endBytes);
var buffer = new ReadOnlySequence<byte>(first, 0, last, last.Memory.Length); |
|
Seems like we have a bug somewhere. /cc @benaadams |
|
Couldn't update this pull request: Head commit author 'ahsonkhan' is not 'dotnet-maestro-bot' |
|
Thanks @benaadams! |
|
@ahsonkhan did it pass? |
Except for the two tests that I skipped (waiting for new corefx build with dotnet/corefx#27691), yes, it passed. The OSX legs are broken https://github.com/dotnet/core-eng/issues/2808 |

/cc @dotnet/corefxlab-contrib