Skip to content
This repository was archived by the owner on Aug 2, 2023. It is now read-only.

Update Cli, CoreFx, CoreFx, CoreFx, CoreFx, CoreFx, CoreSetup, CoreSetup to preview2-008290, preview2-26303-02, preview2-26303-02, preview2-26303-02, preview2-26303-02, preview2-26303-02, preview2-26228-04, preview2-26228-04, respectively (master)#2142

Merged
ahsonkhan merged 5 commits into
dotnet:masterfrom
dotnet-maestro-bot:master-UpdateDependencies
Mar 4, 2018

Conversation

@dotnet-maestro-bot
Copy link
Copy Markdown
Contributor

@dotnet-maestro-bot dotnet-maestro-bot commented Mar 3, 2018

/cc @dotnet/corefxlab-contrib

@dotnet-maestro-bot dotnet-maestro-bot force-pushed the master-UpdateDependencies branch from 76bec76 to 64c68e3 Compare March 3, 2018 00:57
@dotnet-maestro-bot dotnet-maestro-bot changed the title Update Cli, CoreFx, CoreFx, CoreFx, CoreFx, CoreFx, CoreSetup, CoreSetup to preview2-008290, preview2-26228-08, preview2-26228-08, preview2-26228-08, preview2-26228-08, preview2-26228-08, preview2-26228-04, preview2-26228-04, respectively (master) Update Cli, CoreFx, CoreFx, CoreFx, CoreFx, CoreFx, CoreSetup, CoreSetup to preview2-008290, preview2-26303-01, preview2-26303-01, preview2-26303-01, preview2-26303-01, preview2-26303-01, preview2-26228-04, preview2-26228-04, respectively (master) Mar 3, 2018
@dotnet-maestro-bot dotnet-maestro-bot force-pushed the master-UpdateDependencies branch from 64c68e3 to 11776e6 Compare March 3, 2018 03:07
…tup to preview2-008290, preview2-26303-02, preview2-26303-02, preview2-26303-02, preview2-26303-02, preview2-26303-02, preview2-26228-04, preview2-26228-04, respectively
@dotnet-maestro-bot dotnet-maestro-bot changed the title Update Cli, CoreFx, CoreFx, CoreFx, CoreFx, CoreFx, CoreSetup, CoreSetup to preview2-008290, preview2-26303-01, preview2-26303-01, preview2-26303-01, preview2-26303-01, preview2-26303-01, preview2-26228-04, preview2-26228-04, respectively (master) Update Cli, CoreFx, CoreFx, CoreFx, CoreFx, CoreFx, CoreSetup, CoreSetup to preview2-008290, preview2-26303-02, preview2-26303-02, preview2-26303-02, preview2-26303-02, preview2-26303-02, preview2-26228-04, preview2-26228-04, respectively (master) Mar 3, 2018
@dotnet-maestro-bot dotnet-maestro-bot force-pushed the master-UpdateDependencies branch from 11776e6 to 4ea377b Compare March 3, 2018 05:43
@ahsonkhan
Copy link
Copy Markdown
Contributor

ahsonkhan commented Mar 3, 2018

cc @atsushikan, @pakrym, @davidfowl, @KrzysztofCwalina, @benaadams, @eerhardt - please review.

We are grabbing the latest packages (< 2 hours old).

Several tests are failing now, but the build failures have been resolved. Investigation pending.
image

** Build failed. 4 projects failed to build or test. **
    D:\GitHub\Fork\corefxlab\scripts\..\tests\System.Buffers.Experimental.Tests\System.Buffers.Experimental.Tests.csproj
    D:\GitHub\Fork\corefxlab\scripts\..\tests\System.Buffers.Primitives.Tests\System.Buffers.Primitives.Tests.csproj
    D:\GitHub\Fork\corefxlab\scripts\..\tests\System.IO.Pipelines.Extensions.Tests\System.IO.Pipelines.Extensions.Tests.csproj
    D:\GitHub\Fork\corefxlab\scripts\..\tests\System.Text.Http.Parser.Tests\System.Text.Http.Parser.Tests.csproj

Most of the failures have to do with ReadOnlySequence:

Error Message:
 System.InvalidOperationException : End position was not reached during enumeration.

OR

Message: System.ArgumentOutOfRangeException : Specified argument was out of the range of valid values.
Parameter name: endIndex

For example, the ReadOnlySequence constructor is throwing ArgumentOutOfRangeException exception now:
https://github.com/dotnet/corefxlab/blob/master/tests/System.Text.Http.Parser.Tests/HttpParserBasicTests.cs#L52
https://github.com/dotnet/corefx/blob/39418b1d1f0a121d3a9dbaedcf8fa52ea0bea185/src/System.Memory/src/System/ThrowHelper.cs#L143

var parser = new HttpParser();

for (int pivot = 26; pivot < requestText.Length; pivot++) {
    var front = requestText.Substring(0, pivot);
    var back = requestText.Substring(pivot);

    var frontBytes = Encoding.ASCII.GetBytes(front);
    var endBytes = Encoding.ASCII.GetBytes(back);

    var (first, last) = BufferList.Create(frontBytes, endBytes);
    var buffer = new ReadOnlySequence<byte>(first, 0, last, last.Memory.Length);

@davidfowl
Copy link
Copy Markdown
Member

Seems like we have a bug somewhere.

/cc @benaadams

@dotnet-maestro-bot
Copy link
Copy Markdown
Contributor Author

Couldn't update this pull request: Head commit author 'ahsonkhan' is not 'dotnet-maestro-bot'
Would have applied 'Update Cli, CoreFx, CoreFx, CoreFx, CoreFx, CoreFx, CoreSetup, CoreSetup to preview2-008290, preview2-26303-04, preview2-26303-04, preview2-26303-04, preview2-26303-04, preview2-26303-04, preview2-26228-04, preview2-26228-04, respectively'

@ahsonkhan
Copy link
Copy Markdown
Contributor

ahsonkhan commented Mar 4, 2018

I cherry-picked 6851d4b (and modified it a bit - added back CopyTo and TryGet) from #2143

@ahsonkhan ahsonkhan merged commit 22c2d4e into dotnet:master Mar 4, 2018
@ahsonkhan
Copy link
Copy Markdown
Contributor

Thanks @benaadams!

@davidfowl
Copy link
Copy Markdown
Member

@ahsonkhan did it pass?

@ahsonkhan
Copy link
Copy Markdown
Contributor

ahsonkhan commented Mar 4, 2018

did it pass?

Except for the two tests that I skipped (waiting for new corefx build with dotnet/corefx#27691), yes, it passed. The OSX legs are broken https://github.com/dotnet/core-eng/issues/2808

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants