This repository was archived by the owner on Nov 1, 2020. It is now read-only.
Enable multi-module for CoreCLR tests#2765
Merged
nattress merged 1 commit intodotnet:masterfrom Feb 17, 2017
Merged
Conversation
* Allows runtest.cmd /multimodule /coreclr * Modify build integration targets to allow for tests with multiple assemblies. We have two set of assembly inputs to ILC: @(ManagedLibrary) which despite being an Item contains the main managed assembly to use as the template name for the response file and output object file base name. @(IlcCompileInput) is the list of assemblies that are inputs to Ilc. This change allows us to compile all the app assemblies into a single object file. * Specify the inputs / outputs to the MSBuild task that builds the framework assembly obj files. This removes a page of spam per test when MSBuild skips over the already-built obj files. * Currently 12 tests fail due to some EH issue that needs investigating.
sergiy-k
approved these changes
Feb 17, 2017
Member
|
I think this is causing about 70 new failures in the rolling build: I assume it's because we allow passing all sorts of garbage as There are about 70 more failures in the rolling build due to a RyuJIT update. I'll have a closer look at them later in the week and file issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
assemblies. We have two set of assembly inputs to ILC: @(ManagedLibrary)
which despite being an Item contains the main managed assembly to use as
the template name for the response file and output object file base
name. @(IlcCompileInput) is the list of assemblies that are inputs to
Ilc. This change allows us to compile all the app assemblies into a
single object file.
framework assembly obj files. This removes a page of spam per test when
MSBuild skips over the already-built obj files.