Skip to content
This repository was archived by the owner on Nov 1, 2020. It is now read-only.

Fix F5 debugging of ILCompiler project#5422

Merged
MichalStrehovsky merged 1 commit intodotnet:masterfrom
jkotas:fix-debugging
Feb 22, 2018
Merged

Fix F5 debugging of ILCompiler project#5422
MichalStrehovsky merged 1 commit intodotnet:masterfrom
jkotas:fix-debugging

Conversation

@jkotas
Copy link
Copy Markdown
Member

@jkotas jkotas commented Feb 22, 2018

Trying to debug ILCompiler in Visual Studio was failing with missing assemblies. The problem was caused by recently added libLLVMdep.depproj reference that made NuGet delete certain files from the output tools directory. The fix is to move the .depproj reference to a different part of the build next to other similar .depproj reference where it won't be confusing NuGet.

Trying to debug ILCompiler in Visual Studio was failing with missing assemblies. The problem was caused by recently added libLLVMdep.depproj reference that made NuGet delete certain files from the output tools directory. The fix is to move the .depproj reference to a different part of the build next to other similar .depproj reference where it won't be confusing NuGet.
Copy link
Copy Markdown
Member

@MichalStrehovsky MichalStrehovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@MichalStrehovsky MichalStrehovsky merged commit 5ec6a6b into dotnet:master Feb 22, 2018
@jkotas jkotas deleted the fix-debugging branch February 22, 2018 07:42
@morganbr
Copy link
Copy Markdown
Contributor

Thank you! This fixes a really painful problem

@morganbr
Copy link
Copy Markdown
Contributor

It looks like this still doesn't work quite right. It does fix the missing NuGet dependencies, but VS build is still deleting libllvm.dll from the tools directory.

@jkotas
Copy link
Copy Markdown
Member Author

jkotas commented Feb 22, 2018

That has to do with the HostOS hack discussed here:

#5297 (comment)
#5297 (comment)

#5427 should fix it.

kbaladurin pushed a commit to kbaladurin/corert that referenced this pull request Mar 15, 2018
Trying to debug ILCompiler in Visual Studio was failing with missing assemblies. The problem was caused by recently added libLLVMdep.depproj reference that made NuGet delete certain files from the output tools directory. The fix is to move the .depproj reference to a different part of the build next to other similar .depproj reference where it won't be confusing NuGet.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants