Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use plain clang by default on Linux #7948

Merged
merged 2 commits into from Jan 11, 2020
Merged

Use plain clang by default on Linux #7948

merged 2 commits into from Jan 11, 2020

Conversation

@jkotas
Copy link
Member

jkotas commented Jan 10, 2020

clang-3.9 is not available on recent Linux distros. Typically, there is clang alias setup for a good version of clang so just use that by default.

Fixes #5654

@jkotas

This comment has been minimized.

Copy link
Member Author

jkotas commented Jan 10, 2020

I have not tested the all scripts and instructions work in all possible places, so I expect that there will be some follow ups as people run into things that do not work anymore. But I believe that using the non-versioned clang by default is the right long-term choice.

clang-3.9 is not available on recent Linux distros. Typically, there is clang alias setup for a good version of clang so just use that by default.

Fixes #5654
@jkotas jkotas force-pushed the jkotas:clang branch from d6269de to 19da3d9 Jan 10, 2020
@jkotas jkotas force-pushed the jkotas:clang branch from 19da3d9 to 88b5f93 Jan 11, 2020
@jkotas jkotas requested a review from MichalStrehovsky Jan 11, 2020
Copy link
Member

MichalStrehovsky left a comment

I have not tested the all scripts and instructions work in all possible places, so I expect that there will be some follow ups as people run into things

Sounds like a good plan!

@MichalStrehovsky MichalStrehovsky merged commit 42f1bc0 into dotnet:master Jan 11, 2020
12 checks passed
12 checks passed
WIP Ready for review
Details
corert-ci Build #20200111.1 succeeded
Details
corert-ci (Build Linux x64 debug and CoreCLR tests) Build Linux x64 debug and CoreCLR tests succeeded
Details
corert-ci (Build Linux x64 debug and CoreFX tests) Build Linux x64 debug and CoreFX tests succeeded
Details
corert-ci (Build Linux x64 release) Build Linux x64 release succeeded
Details
corert-ci (Build OSX x64 debug and CoreCLR tests) Build OSX x64 debug and CoreCLR tests succeeded
Details
corert-ci (Build OSX x64 debug and CoreFX tests) Build OSX x64 debug and CoreFX tests succeeded
Details
corert-ci (Build OSX x64 release) Build OSX x64 release succeeded
Details
corert-ci (Build Windows_NT x64 debug and CoreCLR tests) Build Windows_NT x64 debug and CoreCLR tests succeeded
Details
corert-ci (Build Windows_NT x64 debug and CoreFX tests) Build Windows_NT x64 debug and CoreFX tests succeeded
Details
corert-ci (Build Windows_NT x64 release) Build Windows_NT x64 release succeeded
Details
license/cla All CLA requirements met.
Details
@jkotas jkotas deleted the jkotas:clang branch Jan 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.