Fixes forwarding https URLs on mac#1768
Merged
Merged
Conversation
garrytrinder
approved these changes
Jul 20, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Kestrel proxy connection handler’s parsing/validation of absolute-form request targets, presumably to improve reliability when forwarding requests that arrive with an https:// absolute URL (notably on macOS system-proxy clients).
Changes:
- Tighten request-target validation by requiring an absolute URI and restricting allowed URI schemes (currently
http/httpsonly).
Comment on lines
+281
to
285
| if (!Uri.TryCreate(absoluteUrl, UriKind.Absolute, out var requestUri) | ||
| || (requestUri.Scheme != "http" && requestUri.Scheme != "https")) | ||
| { | ||
| await WriteErrorAsync(clientStream, HttpStatusCode.BadRequest, "Malformed request target", ct).ConfigureAwait(false); | ||
| return false; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.