Harden dotnet-trace process probe test - #5950
Merged
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 60755fc2-f7b0-4a1e-baa1-a9b772b7e9be
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens the dotnet-trace Linux probe functional test by making its output sanitizer tolerant of an optional “could not be probed” section that can appear when a discovered process exits before diagnostic-port probing completes. This keeps the test validating stable, expected output while avoiding flakiness from inherently non-atomic process enumeration/probing.
Changes:
- Updated
CollectLinuxProbeSanitizerto filter the optional console heading: “.NET processes that could not be probed:”. - Continued filtering process rows (PID-prefixed lines) so the test compares only stable headings/structure.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
/ba-g failure is #5910 |
hoyosjs
enabled auto-merge (squash)
August 5, 2026 06:05
noahfalk
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make
CollectLinuxCommand_Probe_ListsProcesses_WhenNoArgstolerate the optional unprobeable-process section emitted when an enumerated .NET process exits before diagnostic-port probing.The sanitizer continues validating the stable probe output while filtering only process rows and the exact optional section heading. There are no product behavior changes.