Skip to content

fix: MD027/no-multiple-space-blockquote#13910

Merged
mairaw merged 3 commits intodotnet:masterfrom
nschonni:fix--MD027/no-multiple-space-blockquote
Aug 21, 2019
Merged

fix: MD027/no-multiple-space-blockquote#13910
mairaw merged 3 commits intodotnet:masterfrom
nschonni:fix--MD027/no-multiple-space-blockquote

Conversation

@nschonni
Copy link
Copy Markdown
Contributor

@nschonni nschonni commented Aug 19, 2019 •
edited
Loading

ultiple spaces after blockquote symbol.

Find:> \[!NOTE\]
> \s+
Replace:> [!NOTE]
>

@BillWagner
Copy link
Copy Markdown
Member

BillWagner commented Aug 19, 2019

@nschonni I gave this a quick look this morning. Overall, it looks good.

Can you rebase to fix the conflicts? Once that's done, I can check the build report, and look at the review site to make sure it's ready to merge. Thank you.

@mairaw mairaw added this to the August 2019 milestone Aug 19, 2019
mairaw
mairaw requested changes Aug 19, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking as request changes based on @BillWagner's comments

@nschonni
fix: MD027/no-multiple-space-blockquote
70c41d2 
Multiple spaces after blockquote symbol.
Find: > \[!NOTE\]
> \s+
Replace:> [!NOTE]
>
@nschonni nschonni force-pushed the fix--MD027/no-multiple-space-blockquote branch from 1263ef0 to 70c41d2 Compare August 20, 2019 00:17
@nschonni
Copy link
Copy Markdown
Contributor Author

nschonni commented Aug 20, 2019

rebased and re-did the find/replace.
Note: there are others like this with different levels on indentation, so I didn't re-enable the rule yet.

BillWagner
BillWagner approved these changes Aug 20, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nschonni

I did several spot checks on the review site, in addition to spot checks on the source.

This LGTM, and I'll :shipit: now.

Thanks again for helping us work on improving our markdown.

@BillWagner
Copy link
Copy Markdown
Member

BillWagner commented Aug 20, 2019

@mairaw This LGTM. Can you approve and :shipit:?

mairaw
mairaw approved these changes Aug 21, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just resolved some merge conflicts...

@mairaw mairaw requested a review from Thraka as a code owner August 21, 2019 05:25
@mairaw mairaw merged commit d784b6c into dotnet:master Aug 21, 2019
@nschonni nschonni deleted the fix--MD027/no-multiple-space-blockquote branch August 21, 2019 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BillWagner BillWagner BillWagner approved these changes

@mairaw mairaw mairaw approved these changes

@HongGit HongGit Awaiting requested review from HongGit

@karelz karelz Awaiting requested review from karelz

@KathleenDollard KathleenDollard Awaiting requested review from KathleenDollard

@rpetrusha rpetrusha Awaiting requested review from rpetrusha

@stevestein stevestein Awaiting requested review from stevestein

@Thraka Thraka Awaiting requested review from Thraka

Assignees

@nschonni nschonni

Labels

None yet

Projects

None yet

Milestone

August 2019

Development

Successfully merging this pull request may close these issues.

3 participants

@nschonni @BillWagner @mairaw