Skip to content

US 1583733 Add missing language IDs - 15#14236

Merged
rpetrusha merged 4 commits intodotnet:masterfrom
v-thpra:US1583733-batch-15
Oct 5, 2019
Merged

US 1583733 Add missing language IDs - 15#14236
rpetrusha merged 4 commits intodotnet:masterfrom
v-thpra:US1583733-batch-15

Conversation

@v-thpra
Copy link
Copy Markdown
Contributor

@v-thpra v-thpra commented Sep 5, 2019

US 1583733 - Fix CATS P1 issues by adding missing language IDs to code blocks.

  • Used "output" for output displayed in the console. Used "console for console commands.
  • Used "console" for sqlmetal command examples.
  • Used "sql" for examples of stored procedures in LINQ to SQL.

Contributes to #2192

@v-thpra v-thpra requested a review from stevestein as a code owner September 5, 2019 19:18
@Thraka Thraka added the vendor-project Indicates the issue/pr is related to a vendor project. label Sep 5, 2019
@mairaw mairaw added this to the September 2019 milestone Sep 9, 2019
@mairaw
Copy link
Copy Markdown
Contributor

mairaw commented Sep 9, 2019

For outputs displayed on the console, I'd also use console. Only when it's a different output, I'd use output.

@v-thpra
Copy link
Copy Markdown
Contributor Author

v-thpra commented Sep 9, 2019

Good policy regarding console vs. output. I made the changes in this PR, and I'll review the other PRs that I've done to see if more changes are needed.

@v-thpra
Copy link
Copy Markdown
Contributor Author

v-thpra commented Sep 24, 2019

@mairaw All changes and conflicts have been addressed. This should be ready to merge. Thanks!

Copy link
Copy Markdown
Contributor

@rpetrusha rpetrusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @v-thpra, especially for changing output to console. I'll merge your PR now.

@rpetrusha rpetrusha merged commit bafeabf into dotnet:master Oct 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

vendor-project Indicates the issue/pr is related to a vendor project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants