Skip to content

VS2017 Getting Started doc updates#1679

Merged
guardrex merged 9 commits into
dotnet:masterfrom
guardrex:GuardRex-guardrex/vs2017-rtm-getting-started-updates
May 3, 2017
Merged

VS2017 Getting Started doc updates#1679
guardrex merged 9 commits into
dotnet:masterfrom
guardrex:GuardRex-guardrex/vs2017-rtm-getting-started-updates

Conversation

@guardrex
Copy link
Copy Markdown
Contributor

@guardrex guardrex commented Mar 8, 2017

Fixes #1480

(Attempting a squashed commits version here.)

Notes

  • Still rough! Ruf! Ruf! 🐕 Even after review and merge, I'd like to come back in a week or two and work these a bit more.
  • New images! ... but more needed in a few spots. Let's not hold it up tho just for a couple that I can add later.
  • Propose we keep the old images in the media folder. They might be linked into other docs. After all docs in this area have dedicated static asset folders for their images, we can delete all of the images in the media folder safely.
  • If there are more docs that need updating under Review topics that use Visual Studio 2017 RC #1480, I can do those, but I suppose not holding up the whole 🌏 planet 🌍 for these would be good.
  • @mairaw I don't think you added the red stroke outlines to the images you did for VS2017 RTM initial update #1663. I got it covered ... I opened Add stroke outlines to images #1675 for it.

I'll remove the WIP label after the build runs and I fix any broken links.

I'll ping when it's ready for a 👀 look 👀.

@dnfclas
Copy link
Copy Markdown

dnfclas commented Mar 8, 2017

@guardrex,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

guardrex
guardrex commented Mar 8, 2017
View reviewed changes
Comment thread docs/csharp/getting-started/debugging-with-visual-studio-2017.md Outdated
Copy link
Copy Markdown
Contributor Author

@guardrex guardrex Mar 8, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

choosing 👉 selecting

guardrex
guardrex commented Mar 8, 2017
View reviewed changes
Comment thread .openpublishing.redirection.json Outdated
Copy link
Copy Markdown
Contributor Author

@guardrex guardrex Mar 8, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this redirect .... this one had to stay the same

Copy link
Copy Markdown
Contributor

@mairaw mairaw Mar 9, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why?

Copy link
Copy Markdown
Contributor Author

@guardrex guardrex Mar 9, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't rename that one (or the publishing one). The debugging-with-visual-studio.md and the publishing-with-visual-studio.md are 301 redirecting.

Did you want to ignore that and move the content over to those files anyway?

Copy link
Copy Markdown
Contributor Author

@guardrex guardrex Mar 9, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double-301? ... If a proxy or a system has a cached 301 on the non-2017 address and they request the 2017-version of the doc ... it then 301's back to the non-2017 doc. Hum. 🤔
EDIT: Should be ok. I expect a cache update when the 301 goes back (I hope).

guardrex
guardrex commented Mar 8, 2017
View reviewed changes
Comment thread .openpublishing.redirection.json Outdated
Copy link
Copy Markdown
Contributor Author

@guardrex guardrex Mar 8, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this redirect .... this one had to stay the same

@guardrex guardrex added this to the March 2017 milestone Mar 8, 2017
@guardrex guardrex self-assigned this Mar 8, 2017
@guardrex guardrex mentioned this pull request Mar 9, 2017
Merged
mairaw
mairaw reviewed Mar 9, 2017
View reviewed changes
Copy link
Copy Markdown
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't finished my review, but so far, so good!

Comment thread docs/csharp/getting-started/library-with-visual-studio.md Outdated
Copy link
Copy Markdown
Contributor

@mairaw mairaw Mar 9, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should the project name be inline code?

Copy link
Copy Markdown
Contributor Author

@guardrex guardrex Mar 9, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was trying to follow the existing pattern where if the user is directed to type something the text is in quotes. In other places, the project name is in-line code.

Copy link
Copy Markdown
Contributor

@mairaw mairaw Mar 9, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good point.

Comment thread docs/csharp/getting-started/library-with-visual-studio.md Outdated
Copy link
Copy Markdown
Contributor

@mairaw mairaw Mar 9, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wondering if we also should start adding the Prev and Next buttons

@mairaw mairaw removed this from the March 2017 milestone Mar 29, 2017
@guardrex guardrex mentioned this pull request Mar 29, 2017
Closed
@BillWagner
Copy link
Copy Markdown
Member

BillWagner commented Apr 17, 2017

@guardrex Can you update the merge conflicts here as well?

@guardrex guardrex changed the title VS2017 Getting Started doc updates [WIP] VS2017 Getting Started doc updates Apr 17, 2017
@guardrex guardrex added the WIP label Apr 17, 2017
@guardrex
Copy link
Copy Markdown
Contributor Author

guardrex commented Apr 17, 2017

@BillWagner Conflicts seem* to be fixed.

seem* = I better go back over the changes one more time and see how the report looks after the build finishes. I'll remove the WIP label and ping you when ready.

@guardrex guardrex changed the title [WIP] VS2017 Getting Started doc updates VS2017 Getting Started doc updates Apr 18, 2017
@guardrex guardrex removed the WIP label Apr 18, 2017
@guardrex
Copy link
Copy Markdown
Contributor Author

guardrex commented Apr 18, 2017

@BillWagner ready for 👀

guardrex and others added 8 commits April 21, 2017 12:50
@guardrex
Update .openpublishing.redirection.json
2a8b967
@guardrex
Update getting-started.md
826f6cf
@guardrex
Update index.md
07a2e15 
Update toc.md

Update index.md

Update testing-library-with-visual-studio.md

Update debugging-with-visual-studio.md

Update index.md

Update publishing-with-visual-studio-2017.md

Update consuming-library-with-visual-studio-2017.md

Update with-visual-studio-2017.md

Update libraries-with-vs.md

Update .openpublishing.redirection.json

Update publishing-with-visual-studio.md

Update debugging-with-visual-studio-2017.md

Create consuming-library-with-visual-studio.md

Delete consuming-library-with-visual-studio-2017.md

Update debugging-with-visual-studio.md

Update toc.md

Update index.md

Update index.md

Update publishing-with-visual-studio-2017.md

Update consuming-library-with-visual-studio.md

Update with-visual-studio-2017.md

Create library-with-visual-studio.md

Delete library-with-visual-studio-2017.md

Update publishing-with-visual-studio.md

Update toc.md

Update index.md

Update index.md

Update consuming-library-with-visual-studio.md

Update with-visual-studio-2017.md

Update debugging-with-visual-studio-2017.md

Update consuming-library-with-visual-studio.md

Update debugging-with-visual-studio-2017.md

Update consuming-library-with-visual-studio.md

Update library-with-visual-studio.md

Update publishing-with-visual-studio-2017.md

Update library-with-visual-studio.md

Create new_project.png

Add files via upload

Update library-with-visual-studio.md

Add files via upload

Delete class_library.png

Add files via upload

Delete class_library.png

Add files via upload

Update library-with-visual-studio.md

Create use-library.png

Delete build_succeeded.png

Delete lib_project.png

Delete new_project.png

Delete string_library.png

Create newproject.png

Add files via upload

Update library-with-visual-studio.md

Update consuming-library-with-visual-studio.md

Add files via upload

Delete buildsucceeded.png

Add files via upload

Update library-with-visual-studio.md

Update consuming-library-with-visual-studio.md

Create debugmode.png

Add files via upload

Update debugging-with-visual-studio-2017.md

Create toolbar1.png

Add files via upload

Update publishing-with-visual-studio-2017.md

Delete publish2.png

Delete toolbar1.png

Add files via upload

Update publishing-with-visual-studio-2017.md

Update publishing-with-visual-studio-2017.md

Create testproject.png

Add files via upload

Update testing-library-with-visual-studio.md

Delete uittestwindow.png

Add files via upload

Update library-with-visual-studio.md

Update consuming-library-with-visual-studio.md

Update consuming-library-with-visual-studio.md

Update consuming-library-with-visual-studio.md

Update consuming-library-with-visual-studio.md

Update consuming-library-with-visual-studio.md

Update debugging-with-visual-studio-2017.md

Update debugging-with-visual-studio-2017.md

Update debugging-with-visual-studio-2017.md

Update debugging-with-visual-studio-2017.md

Update debugging-with-visual-studio-2017.md

Update debugging-with-visual-studio-2017.md

Update debugging-with-visual-studio-2017.md

Update debugging-with-visual-studio-2017.md

Update debugging-with-visual-studio-2017.md

Update debugging-with-visual-studio-2017.md

Update debugging-with-visual-studio-2017.md

Update debugging-with-visual-studio-2017.md

Update debugging-with-visual-studio-2017.md

Update debugging-with-visual-studio-2017.md

Update debugging-with-visual-studio-2017.md

Update debugging-with-visual-studio-2017.md

Update debugging-with-visual-studio-2017.md

Update consuming-library-with-visual-studio.md

Update library-with-visual-studio.md

Update publishing-with-visual-studio-2017.md

Update testing-library-with-visual-studio.md

Update testing-library-with-visual-studio.md

Update testing-library-with-visual-studio.md

Update testing-library-with-visual-studio.md

Update testing-library-with-visual-studio.md

Update testing-library-with-visual-studio.md

Update testing-library-with-visual-studio.md

Update testing-library-with-visual-studio.md

Update testing-library-with-visual-studio.md

Update testing-library-with-visual-studio.md

Update testing-library-with-visual-studio.md

Update testing-library-with-visual-studio.md

Update debugging-with-visual-studio-2017.md

Update testing-library-with-visual-studio.md

Update getting-started.md

Update toc.md
Move remaining 2017 docs
8f23f3b
Updates
4e3a49e
Updates
c1ab50f
Updates
214d078
Minor update
20e5db8
BillWagner
BillWagner approved these changes May 2, 2017
View reviewed changes
Copy link
Copy Markdown
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. I'd agree with @mairaw that the Prev and Next buttons would be useful for readers. Adding them would be a good idea, but not a blocker to merging.

@guardrex guardrex merged commit 22aab46 into dotnet:master May 3, 2017
@guardrex guardrex deleted the GuardRex-guardrex/vs2017-rtm-getting-started-updates branch May 3, 2017 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mairaw mairaw mairaw left review comments

@BillWagner BillWagner BillWagner approved these changes

Assignees

@guardrex guardrex

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Review topics that use Visual Studio 2017 RC

4 participants

@guardrex @dnfclas @BillWagner @mairaw