Combine sub-TOCs into standard TOC#17660
Merged
gewarren merged 3 commits intodotnet:masterfrom Apr 1, 2020
Merged
Conversation
Contributor
gewarren
commented
Apr 1, 2020
gewarren
commented
- Combine the following sub-TOCS into the /standard/ TOC:
- attributes
- collections
- cross-platform
- events
- exceptions
- garbage-collection
- generics
- io
- parallel-programming
- serialization
- Delete/combine a few dispensable top-level topics
gewarren
requested review from
a team,
BillWagner,
Thraka and
tdykstra
as code owners
gewarren
changed the title
tdykstra
approved these changes
Apr 1, 2020
Contributor
tdykstra
left a comment
tdykstra
left a comment
There was a problem hiding this comment.
LGTM, my only question is why the Security sub-TOC wasn't incorporated into the TOC?
Contributor
Author
Thanks for the review. Good question - there were no security articles with page views over 5000, so I'm not currently planning to add any security articles to the landing page. Also, this PR was taking longer than I'd hoped! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.