Skip to content

Docker & dotnet - add WORKDIR to docker cmd #18043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 24, 2020
Merged

Docker & dotnet - add WORKDIR to docker cmd #18043

merged 1 commit into from
Apr 24, 2020

Conversation

@Thraka
Copy link
Contributor

@Thraka Thraka commented Apr 23, 2020 •
edited
Loading

Summary

  • Added WORKDIR to the docker file example.
  • Adjusted descriptions to fit.
  • Updated docker output.
  • Docker calls the app directly instead of using the /app folder.

Contributes to #17942

@dotnet-bot dotnet-bot added this to the April 2020 milestone Apr 23, 2020
@Thraka Thraka requested a review from BillWagner April 23, 2020 20:27
BillWagner
BillWagner approved these changes Apr 24, 2020
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @Thraka

You can :shipit: when ready.

@Thraka Thraka merged commit 19c98b6 into master Apr 24, 2020
@Thraka Thraka deleted the adegeo-17942 branch April 24, 2020 16:34
@Thraka Thraka self-assigned this Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BillWagner BillWagner BillWagner approved these changes

Assignees

@Thraka Thraka

Labels

dotnet-docker/subsvc

Projects

None yet

Milestone

April 2020

Development

Successfully merging this pull request may close these issues.

4 participants

@Thraka @BillWagner @dotnet-bot