Clarify usage of string interpolation in LINQ Data Transformation #18764
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- refactor query description to clearly describe steps in operation - add brief explanation of string interpolation and link to string interpolation page
- change output sequence variable name from 'query' to 'output' - add linq example using method syntax in addition to query syntax - add allman braces to foreach loop printing results
…-string-interpolation-clarification-data-transformations-with-linq
BillWagner
approved these changes
Jun 3, 2020
Member
BillWagner
left a comment
BillWagner
left a comment
There was a problem hiding this comment.
Thanks for helping us improve @jmarkman
I've reviewed this PR, and I'll 
now.
Thanks again. We appreciate it.
jmarkman
deleted the
jmarkman-string-interpolation-clarification-data-transformations-with-linq
branch
BillWagner
added
dotnet-csharp/svc
csharp-linq/subsvc
and removed
📚 Area - C# Guide
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
User 'Vespiyanus' opened an issue to ask about the
$operator, as it wasn't clear what exactly that operator was doing from their point of view. I've reviewed the "Performing Operations on Source Elements" section and made some modifications:The explanation for the query, while correct, was excessively verbose and did not reflect the brevity and clarity of the code example itself. I rewrote the explanation to describe the whole operation that the query example encompassed.
I've done this for previous pull requests that involved LINQ. While this example is incredibly simple (it's just a
select), I think it's good for users of all skill levels to see what a query might look like with both forms of syntax, but more for newer folks especially.Fixes #18681