Skip to content

Conversation

@bradleyscollins
Copy link
Contributor

Title

Corrected IPAddress.Parse method example.

Summary

Corrected 1st example in Remarks section. Changed "65536" to "65535".

Details

IPAddress.Parse("65536") actually produces 0.1.0.0. IPAddress.Parse("65535") produces 0.0.255.255. Changed the first example under the Number of parts and example ipString column from "65536" to "65535" to match the answer in IPv4 address for IPAddress column.

Corrected 1st example in "Remarks" section. `IPAddress.Parse("65536")` actually produces `0.1.0.0`.

`IPAddress.Parse("65535")` produces `0.0.255.255`.
@dnfclas
Copy link

dnfclas commented Apr 14, 2017

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

@dnfclas
Copy link

dnfclas commented Apr 14, 2017

@bradleyscollins, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.

Thanks, .NET Foundation Pull Request Bot

@guardrex
Copy link
Contributor

Confirmed correct. Let's get this merged as soon as the build completes.

Thanks @bradleyscollins!

@guardrex guardrex removed Area - API Reference external Not related to content labels Apr 14, 2017
@svick
Copy link
Contributor

svick commented Apr 15, 2017

@guardrex Isn't there some way to rerun the build while staying with the same PR, maybe closing and reopening the PR?

Also, the build failure says "There is not enough space on the disk." Has that been fixed? Otherwise a new build is likely going to run into the same issue.

@guardrex
Copy link
Contributor

guardrex commented Apr 15, 2017

@svick Let's try that. I did once before close/reopen to get a good one. I hoped for an option to rebuild in the pub service UI, but I don't see a way to do it from there. There have been some good builds since this one failed; so hopefully, this failure was just a one-off.

@guardrex guardrex closed this Apr 15, 2017
@guardrex guardrex reopened this Apr 15, 2017
@dnfclas
Copy link

dnfclas commented Apr 15, 2017

@bradleyscollins,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

@guardrex
Copy link
Contributor

@svick 🥇 Licked IT! Thx. @bradleyscollins thanks for correcting this! 🎸

@guardrex guardrex merged commit f9b4931 into dotnet:master Apr 15, 2017
@bradleyscollins
Copy link
Contributor Author

@guardrex, sorry for going radio silence on you there: Been out of pocket the last few days. Thank you for merging it for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants