-
Notifications
You must be signed in to change notification settings - Fork 6.1k
Corrected typo in System.Net.IPAddress.Parse example #1914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Corrected 1st example in "Remarks" section. `IPAddress.Parse("65536")` actually produces `0.1.0.0`.
`IPAddress.Parse("65535")` produces `0.0.255.255`.
|
This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request. |
|
@bradleyscollins, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request. |
|
Confirmed correct. Let's get this merged as soon as the build completes. Thanks @bradleyscollins! |
|
@guardrex Isn't there some way to rerun the build while staying with the same PR, maybe closing and reopening the PR? Also, the build failure says "There is not enough space on the disk." Has that been fixed? Otherwise a new build is likely going to run into the same issue. |
|
@svick Let's try that. I did once before close/reopen to get a good one. I hoped for an option to rebuild in the pub service UI, but I don't see a way to do it from there. There have been some good builds since this one failed; so hopefully, this failure was just a one-off. |
|
@bradleyscollins, |
|
@svick 🥇 Licked IT! Thx. @bradleyscollins thanks for correcting this! 🎸 |
|
@guardrex, sorry for going radio silence on you there: Been out of pocket the last few days. Thank you for merging it for me. |
Title
Corrected
IPAddress.Parsemethod example.Summary
Corrected 1st example in Remarks section. Changed
"65536"to"65535".Details
IPAddress.Parse("65536")actually produces0.1.0.0.IPAddress.Parse("65535")produces0.0.255.255. Changed the first example under the Number of parts and example ipString column from"65536"to"65535"to match the answer in IPv4 address for IPAddress column.