-
Notifications
You must be signed in to change notification settings - Fork 6.1k
Document dotnet-gcdump tool #19697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document dotnet-gcdump tool #19697
Conversation
tdykstra
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good start -- I had a few doc structure and wording suggestions. I would put this in the TOC following dotnet-dump
| dotnet-gcdump collect [-h|--help] [-p|--process-id <pid>] [-o|--output <gcdump-file-path>] [-v|--verbose] [-t|--timeout <timeout>] [-n|--name <name>] | ||
| ``` | ||
|
|
||
| ### Options |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Following the pattern of https://raw.githubusercontent.com/dotnet/docs/master/docs/core/diagnostics/dotnet-counters.md we should have an Examples h3 section following each Options h3 section.
|
|
||
| - **`-t|--report-type <HeapStat>`** | ||
|
|
||
| The type of report to generate. Available options: heapstat (default). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is the only option, what's the difference between specifying it an omitting it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tdykstra, I had this question myself. It looks like there shouldn't be a difference. Perhaps the tool team might be planning to add other options later?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/cc @josalem
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is only report type available right now and therefore the default, but we created this flag for future use if/when we add more report types.
Co-authored-by: Tom Dykstra <tdykstra@microsoft.com>
Co-authored-by: Tom Dykstra <tdykstra@microsoft.com>
|
The options here are in the same order produced by the CLI help, do you want me to order them alphabetically as done with dotnet-trace? @tdykstra The PR still lacks examples. I'll try adding some. |
There's no reason the docs have to follow the CLI help order; any way we can make the docs more usable seems worth doing to me. In this case the small number of options makes the benefit of limited value, but my preference is to be consistent. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't look like the description section incorporates the info from https://github.com/dotnet/diagnostics/blob/f63dc82eb4d92b8e057f7e3b5855cdf06f985f8c/documentation/dotnet-gcdump-instructions.md#known-caveats and https://github.com/dotnet/diagnostics/blob/f63dc82eb4d92b8e057f7e3b5855cdf06f985f8c/documentation/dotnet-gcdump-instructions.md#viewing-the-gcdump-captured-from-dotnet-gcdump -- is that deliberate?
I'll add these. Thanks for noticing this. |
Co-authored-by: Petr Kulikov <petr.kulikov@gmail.com>
|
|
||
| - **`-t|--report-type <HeapStat>`** | ||
|
|
||
| The type of report to generate. Available options: heapstat (default). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is only report type available right now and therefore the default, but we created this flag for future use if/when we add more report types.
|
@tdykstra Is this good to go or do you have other concerns? |
tdykstra
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple suggestions
|
|
||
| The type of report to generate. Available options: heapstat (default). | ||
|
|
||
| ## Viewing the GC dump captured from dotnet-gcdump |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might fit as an H3 in the Description section
Co-authored-by: Tom Dykstra <tdykstra@microsoft.com>
|
There's still a markdownlint error - we can merge this when that's resolved.
You can save that for a later PR if you prefer. |
I completely forgot about that. If it's okay to merge this, I'll open an issue to track adding examples. Otherwise, I'll find time to add them tomorrow or so. |
|
Yes OK to merge and add later. Thanks for creating this doc! |
Fixes #18935
Information source.
Internal review link.