-
Notifications
You must be signed in to change notification settings - Fork 6.1k
update cli scenarios #21106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update cli scenarios #21106
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@briacht thanks for updating this.
I added a comment. Let me know what you think.
| - recommendation | ||
| - Future: other machine learning tasks such as image-classification, ranking, anomaly-detection, clustering | ||
| - image classification | ||
| - Future: other machine learning tasks such as ranking, anomaly detection, clustering |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we even need this future bullet point. It's not in the product now, so would remove it and just list what the product supports. Sounds more like a promise and might create confusion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, docs shouldn't mention future plans according to the contributor's guide. @briacht Could you update and then we'll merge?
| - recommendation | ||
| - Future: other machine learning tasks such as image-classification, ranking, anomaly-detection, clustering | ||
| - image classification | ||
| - Future: other machine learning tasks such as ranking, anomaly detection, clustering |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, docs shouldn't mention future plans according to the contributor's guide. @briacht Could you update and then we'll merge?
|
@briacht Ping |
|
I had to create a new PR: #23283 Also I got rid of the "Future" statement. |
|
Closing PR since there's a new one. |
Summary
add image classification to cli scenarios