Extract api_surface configurability#21953
Conversation
gewarren
left a comment
gewarren
left a comment
There was a problem hiding this comment.
Left some suggestions to apply throughout.
gewarren
left a comment
gewarren
left a comment
There was a problem hiding this comment.
In addition to these comments, there are 4 warnings to fix:
gewarren
left a comment
gewarren
left a comment
There was a problem hiding this comment.
Please check the pluralization discrepancy throughout.
|
Hopefully this should cover all the remaining points. @gewarren Thank you so much for all your time and feedback! |
gewarren
left a comment
gewarren
left a comment
There was a problem hiding this comment.
Getting there! Thanks for updating these.
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
| You can configure these options for just this rule, for all rules, or for all rules in this category (Usage). For more information, see [Code quality rule configuration options](../code-quality-rule-options.md). | ||
| - [CA2241: Provide correct arguments to formatting methods](#ca2241-provide-correct-arguments-to-formatting-methods) | ||
| - [Cause](#cause) | ||
| - [Rule description](#rule-description) |
There was a problem hiding this comment.
Something weird happened here. Do you have a tool to add the indexes automatically?
There was a problem hiding this comment.
I don't or at least not aware of it, I did the change in VS Code.
There was a problem hiding this comment.
I confirm it automatically happens on save in VS Code. It's not doing that for the other files...
There was a problem hiding this comment.
That's very strange. What extensions do you have installed, and what are the steps to get this to happen?
gewarren
left a comment
gewarren
left a comment
There was a problem hiding this comment.
Looks great, thank you!
4 participants
Summary
Extract
api_surfaceconfigurability.