Skip to content

Conversation

@zedy-wj
Copy link
Contributor

@zedy-wj zedy-wj commented Jun 1, 2021

1.Updating F# doc to the new SDKs - Queue Storage

2.Updated files :

  • i.docs/fsharp/using-fsharp-on-azure/queue-storage.md
  • ii.samples/snippets/fsharp/azure/queue-storage.fsx

@jongio for notification.

@dotnet-bot dotnet-bot added this to the June 2021 milestone Jun 1, 2021
Copy link
Member

@jsquire jsquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zedy-wj
Copy link
Contributor Author

zedy-wj commented Jun 3, 2021

Complete all changes according to comments. Thanks for your guidance!

@zedy-wj zedy-wj marked this pull request as ready for review June 3, 2021 01:34
@zedy-wj zedy-wj changed the title Update F# on Azure Docs Update F# on Azure Docs - Queue Storage Jun 3, 2021
@zedy-wj
Copy link
Contributor Author

zedy-wj commented Jun 7, 2021

Hi, @tg-msft Thanks for your review! Updated according to your comments.

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All comments have been addressed.

This LGTM, and I'll :shipit: now.

@BillWagner BillWagner enabled auto-merge (squash) July 1, 2021 15:27
@BillWagner BillWagner merged commit 9e8d545 into dotnet:main Jul 1, 2021
Youssef1313 pushed a commit to Youssef1313/docs that referenced this pull request Jul 5, 2021
* Updating Queue Storage to the new SDKs.

* Update reference

* test path

* modify format

* Update the doc in queue-storage

* remove invalid changes

* Updating some variables' name and removing invalid changes.

* remove repeat comments after the 3-line header block for each section

* omit the new when creating queueClient.

* Update ReadMe file

* Update Readme file

* Remove en-us in link

* Update docs/fsharp/using-fsharp-on-azure/queue-storage.md

Co-authored-by: Wenjie Yu <v-wenjyu@microsoft.com>
Co-authored-by: Bill Wagner <wiwagn@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants