Skip to content

Add code highlight#3098

Merged
rpetrusha merged 2 commits intodotnet:masterfrom
WenceyWang:patch-1
Sep 13, 2017
Merged

Add code highlight#3098
rpetrusha merged 2 commits intodotnet:masterfrom
WenceyWang:patch-1

Conversation

@WenceyWang
Copy link
Copy Markdown
Contributor

Title

Add code highlight

Summary

previous doc have no code highlight.
added it.

Details

Suggested Reviewers

@dnfclas
Copy link
Copy Markdown

dnfclas commented Sep 8, 2017

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

Copy link
Copy Markdown
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @WenceyWang. Thanks for adding these. It really helps. I just left a comment regarding the identifier that we use for VB.

```

```
```vbnet
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

our build system supports vb instead of vbnet for the fenced code blocks. For more info, see https://github.com/dotnet/docs/blob/master/styleguide/template.md#supported-languages

@mairaw mairaw closed this Sep 11, 2017
@mairaw mairaw reopened this Sep 11, 2017
@dnfclas
Copy link
Copy Markdown

dnfclas commented Sep 11, 2017

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

Copy link
Copy Markdown
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @WenceyWang for adding the identifiers. I'll just wait for a green build before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants