Skip to content

Remove pragma directives #33288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 4, 2023
Merged

Remove pragma directives #33288

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions docs/standard/garbage-collection/implementing-disposeasync.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ title: Implement a DisposeAsync method
description: Learn how to implement DisposeAsync and DisposeAsyncCore methods to perform asynchronous resource cleanup.
author: IEvangelist
ms.author: dapine
ms.date: 11/30/2022
ms.date: 01/02/2023
dev_langs:
- "csharp"
helpviewer_keywords:
Expand Down Expand Up @@ -49,10 +49,8 @@ public async ValueTask DisposeAsync()
// Dispose of unmanaged resources.
Dispose(false);

#pragma warning disable CA1816 // Dispose methods should call SuppressFinalize
// Suppress finalization.
GC.SuppressFinalize(this);
#pragma warning restore CA1816 // Dispose methods should call SuppressFinalize
}
```

Expand Down
2 changes: 0 additions & 2 deletions docs/standard/garbage-collection/snippets/dispose-async/ExampleConjunctiveDisposable.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,7 @@ public async ValueTask DisposeAsync()
await DisposeAsyncCore().ConfigureAwait(false);

Dispose(disposing: false);
#pragma warning disable CA1816 // Dispose methods should call SuppressFinalize
GC.SuppressFinalize(this);
#pragma warning restore CA1816 // Dispose methods should call SuppressFinalize
}

protected virtual void Dispose(bool disposing)
Expand Down