🔑 Disambiguation for helpviewer keywords in WPF, Winforms, VB#3472
Merged
mairaw merged 10 commits intodotnet:masterfrom Oct 22, 2017
mikeblome:mb-hv4
Merged
🔑 Disambiguation for helpviewer keywords in WPF, Winforms, VB#3472mairaw merged 10 commits intodotnet:masterfrom mikeblome:mb-hv4
mairaw merged 10 commits intodotnet:masterfrom
mikeblome:mb-hv4
Conversation
This was referenced Oct 20, 2017
mairaw
reviewed
Oct 20, 2017
| @@ -12,7 +12,7 @@ ms.topic: "article" | |||
| helpviewer_keywords: | |||
| - "GDI+, about GDI+" | |||
Contributor
There was a problem hiding this comment.
not related to your PR and not asking you to fix this, but having an entry GDI+ and another one GDI+, about GDI+ is not super helpful IMO. Thoughts?
Contributor
Author
There was a problem hiding this comment.
Agreed. I saw many things like this that I would fix if I had a few free days :-) Some topics have way too many keywords, some too few, and some keywords aren't really useful.
Contributor
There was a problem hiding this comment.
Cool. We'll address this separately. Don't worry about this. You're already helping a lot @mikeblome!
mairaw
changed the title
mairaw
approved these changes
Oct 21, 2017
Contributor
mairaw
left a comment
mairaw
left a comment
There was a problem hiding this comment.
LGTM after fixing space issues. I'll merge once it finishes building.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a redo of two earlier PRs only this time no reformatting of tags.