Skip to content

Add the Orleans meters #36931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Sep 6, 2023
Merged

Add the Orleans meters #36931

merged 13 commits into from
Sep 6, 2023

Conversation

@IEvangelist
Copy link
Member

@IEvangelist IEvangelist commented Aug 31, 2023 •
edited by github-actions bot
Loading

Summary

Add the Orleans meters—need help from @ReubenBond for the descriptions of each.

Fixes #33984

Internal previews

📄 File 🔗 Preview link
docs/core/diagnostics/compare-metric-apis.md Metric APIs comparison
docs/orleans/host/monitoring/index.md Orleans observability

@IEvangelist IEvangelist requested a review from gewarren August 31, 2023 16:28
@dotnet-bot dotnet-bot added this to the August 2023 milestone Aug 31, 2023
@ghost ghost added the okr-curation OKR: Curate content to remove outdated recommendations label Aug 31, 2023
@IEvangelist IEvangelist mentioned this pull request Aug 31, 2023
Merged
@IEvangelist IEvangelist marked this pull request as ready for review September 1, 2023 17:08
@IEvangelist IEvangelist requested review from a team and tommcdon as code owners September 1, 2023 17:08
ReubenBond
ReubenBond reviewed Sep 1, 2023
View reviewed changes
ReubenBond
ReubenBond reviewed Sep 1, 2023
View reviewed changes
ReubenBond
ReubenBond reviewed Sep 1, 2023
View reviewed changes
ReubenBond
ReubenBond reviewed Sep 1, 2023
View reviewed changes
BillWagner
BillWagner approved these changes Sep 6, 2023
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a couple suggestions, and then this is ready to :shipit:

IEvangelist
IEvangelist commented Sep 6, 2023
View reviewed changes
IEvangelist
IEvangelist commented Sep 6, 2023
View reviewed changes
IEvangelist
IEvangelist commented Sep 6, 2023
View reviewed changes
IEvangelist
IEvangelist commented Sep 6, 2023
View reviewed changes
IEvangelist
IEvangelist commented Sep 6, 2023
View reviewed changes
IEvangelist
IEvangelist commented Sep 6, 2023
View reviewed changes
IEvangelist
IEvangelist commented Sep 6, 2023
View reviewed changes
IEvangelist
IEvangelist commented Sep 6, 2023
View reviewed changes
IEvangelist
IEvangelist commented Sep 6, 2023
View reviewed changes
IEvangelist
IEvangelist commented Sep 6, 2023
View reviewed changes
IEvangelist
IEvangelist commented Sep 6, 2023
View reviewed changes
IEvangelist
IEvangelist commented Sep 6, 2023
View reviewed changes
IEvangelist
IEvangelist commented Sep 6, 2023
View reviewed changes
IEvangelist
IEvangelist commented Sep 6, 2023
View reviewed changes
IEvangelist
IEvangelist commented Sep 6, 2023
View reviewed changes
@IEvangelist IEvangelist enabled auto-merge (squash) September 6, 2023 15:13
@IEvangelist IEvangelist merged commit 15bb35a into dotnet:main Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ReubenBond ReubenBond ReubenBond left review comments

@BillWagner BillWagner BillWagner approved these changes

@gewarren gewarren Awaiting requested review from gewarren

@tommcdon tommcdon Awaiting requested review from tommcdon tommcdon is a code owner

Assignees

No one assigned

Labels

okr-curation OKR: Curate content to remove outdated recommendations

Projects

None yet

Milestone

August 2023

Development

Successfully merging this pull request may close these issues.

Runtime monitoring - Available statistics and metrics not documented

4 participants

@IEvangelist @ReubenBond @BillWagner @dotnet-bot