Converted msdn links to site-relative for offline scenarios#3896
Merged
mairaw merged 7 commits intodotnet:masterfrom Dec 9, 2017
mikeblome:mb-msdn9
Merged
Converted msdn links to site-relative for offline scenarios#3896mairaw merged 7 commits intodotnet:masterfrom mikeblome:mb-msdn9
mairaw merged 7 commits intodotnet:masterfrom
mikeblome:mb-msdn9
Conversation
mikeblome
changed the title
attempt at link fix
mikeblome
commented
Dec 8, 2017
Contributor
Author
mikeblome
left a comment
mikeblome
left a comment
There was a problem hiding this comment.
@mairaw @BillWagner Link report showed 93, two above baseline of 91, and I attempted to fix one of those inline, so should just be one additional that I introduced possibly. I request that we accept anyway as a net plus in terms of correct links.
Contributor
|
Thanks so much for working on this @mikeblome. We'll review it as soon as possible! |
mairaw
approved these changes
Dec 8, 2017
Contributor
There was a problem hiding this comment.
Thanks @mikeblome. I did a couple of fixes as well that might bring us back to 91. We'll wait for builds to finish before merging.
Contributor
|
Related to #2037 |
mairaw
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes up msdn shortid urls that were missed in earlier runs