Skip to content

Conversation

@AdmiralSnyder
Copy link
Contributor

@AdmiralSnyder AdmiralSnyder commented Oct 28, 2025

those two samples should refer to the same folder structure. which they did not, previously.

Reasoning

i.e. the in the .csproj needs to reference the target project's .csproj
whereas the #:project entry in the .cs references the folder the project is in.


Internal previews

📄 File 🔗 Preview link
docs/csharp/language-reference/preprocessor-directives.md C# preprocessor directives

those two samples should refer to the same
Copilot AI review requested due to automatic review settings October 28, 2025 15:51
@AdmiralSnyder AdmiralSnyder requested review from a team and BillWagner as code owners October 28, 2025 15:51
@dotnetrepoman dotnetrepoman bot added this to the October 2025 milestone Oct 28, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR corrects a documentation inconsistency in the preprocessor directives guide by fixing the ProjectReference path example to properly reflect the folder structure used in the #:project directive example.

Key Changes

  • Updated the XML ProjectReference path to include the project folder in its path structure, ensuring consistency with the #:project directive example that references the folder containing the project.

@dotnet-policy-service dotnet-policy-service bot added dotnet-csharp/svc lang-reference/subsvc community-contribution Indicates PR is created by someone from the .NET community. labels Oct 28, 2025
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AdmiralSnyder

This LGTM. I'll :shipit: now.

@BillWagner BillWagner merged commit 6b44590 into dotnet:main Oct 28, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-contribution Indicates PR is created by someone from the .NET community. dotnet-csharp/svc lang-reference/subsvc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants