Skip to content

Replace Visual C# token#4989

Merged
BillWagner merged 5 commits intodotnet:masterfrom
ErlendLandro:csprcs-md
Apr 24, 2018
Merged

Replace Visual C# token#4989
BillWagner merged 5 commits intodotnet:masterfrom
ErlendLandro:csprcs-md

Conversation

@ErlendLandro
Copy link
Copy Markdown
Contributor

For #4801

@ErlendLandro
Copy link
Copy Markdown
Contributor Author

I'll fix the merge conflicts for this one later today

@ErlendLandro
Copy link
Copy Markdown
Contributor Author

I should have split this PR into two or three different PRs to avoid changes to this many files at once.

Copy link
Copy Markdown
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also great work @Mackiovello

Thank you! I'll :shipit: once you resolve the merge conflicts.

This one is small enough (as a focused search/replace) that I can review it as is without splitting. Thanks for offering to split it up though.

BillWagner added a commit to BillWagner/dotnet-api-docs that referenced this pull request Apr 24, 2018
Related to dotnet/docs#5005 and dotnet/docs#4989

This PR removes the same tokens from the API reference repo.
@ErlendLandro
Copy link
Copy Markdown
Contributor Author

There we go! Should be ready to merge now

@BillWagner
Copy link
Copy Markdown
Member

@Mackiovello There is one build error. It looks like you missed one instance of this include in docs/framework/data/wcf/creating-the-data-service.md

@BillWagner BillWagner merged commit 83c8b55 into dotnet:master Apr 24, 2018
@ErlendLandro ErlendLandro deleted the csprcs-md branch April 24, 2018 17:12
BillWagner added a commit to dotnet/dotnet-api-docs that referenced this pull request Apr 24, 2018
Related to dotnet/docs#5005 and dotnet/docs#4989

This PR removes the same tokens from the API reference repo.
ChrisMaddock pushed a commit to ChrisMaddock/dotnet-api-docs that referenced this pull request Apr 25, 2018
Related to dotnet/docs#5005 and dotnet/docs#4989

This PR removes the same tokens from the API reference repo.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants