Skip to content

Conversation

@AdmiralSnyder
Copy link
Contributor

@AdmiralSnyder AdmiralSnyder commented Nov 25, 2025

Updated customer intent description for clarity and added a reference to directives.

Summary

Describe your changes here.

Fixes #Issue_Number (if available)


Internal previews

📄 File 🔗 Preview link
docs/csharp/fundamentals/tutorials/file-based-programs.md Tutorial: Build file-based C# programs

Updated customer intent description for clarity and added a reference to directives.
Copilot AI review requested due to automatic review settings November 25, 2025 12:10
@AdmiralSnyder AdmiralSnyder requested review from a team and BillWagner as code owners November 25, 2025 12:10
@dotnetrepoman dotnetrepoman bot added this to the November 2025 milestone Nov 25, 2025
@dotnet-policy-service dotnet-policy-service bot added dotnet-csharp/svc fundamentals/subsvc community-contribution Indicates PR is created by someone from the .NET community. labels Nov 25, 2025
Copilot finished reviewing on behalf of AdmiralSnyder November 25, 2025 12:11
@AdmiralSnyder
Copy link
Contributor Author

Here's an additional question. in the document, it's stated that dotnet run has to be used to execute file based projects. iirc, in dotnetconf it was demoed that dotnet myfile.cs was sufficient - shouldn't that be what is recommended in this beginner tutorial (since it removes (unnecessary) console input?

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR makes two small improvements to the file-based programs tutorial: corrects a grammar issue in the customer intent metadata comment (adding "to" before "build"), and enhances the description by adding a cross-reference link to the preprocessor directives documentation where shebang directives are mentioned.

Key Changes

  • Fixed grammar in customer intent comment: "I want build" → "I want to build"
  • Added cross-reference link to preprocessor directives documentation for the shebang directives mention

@BillWagner
Copy link
Member

Here's an additional question. in the document, it's stated that dotnet run has to be used to execute file based projects. iirc, in dotnetconf it was demoed that dotnet myfile.cs was sufficient - shouldn't that be what is recommended in this beginner tutorial (since it removes (unnecessary) console input?

Yes, dotnet myfile.cs is now sufficient. (That's the price of working with previews. @AdmiralSnyder Do you want to add that update to this PR?

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@BillWagner
Copy link
Member

Hi @AdmiralSnyder

What you've written in this PR is fine, and ready to merge. Did you want to add the text about dotnet myfile.cs, or should I make an issue to handle that change in another PR?

I'm happy with either choice, I just want to know if I should leave this open or merge it. Thanks.

@AdmiralSnyder
Copy link
Contributor Author

sorry @BillWagner i thought about it but forgot to actually respond.
i think changing documentation from
dotnet run myfile.cs
to
dotnet myfile.cs
should be a concerted effort touching all the places at once
which i could imagine is a pain when you only use the github web UI (and is more than i have time right now, sadly)

So creating a separate issue for that would be the correct thing to do, imo.

Speaking about creating issues for documentations? can i please get the right to do that? :-) pretty please.

@BillWagner
Copy link
Member

@AdmiralSnyder

Speaking about creating issues for documentations? can i please get the right to do that? :-) pretty please.

This will vary by repository. The repos in the dotnet GitHub org almost all accept issues publicly. The exception are some repos for API docs where the source of truth is the product source. (For example, the roslyn-api-docs repo doesn't accept issues because the roslyn source has the triple slash comments).

In general, on all our docs, you'll see a link to create a docs issue. That link opens a template that makes adds reference links to the article for us:
image

Thanks again.

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM and I'll :shipit: now.

@BillWagner BillWagner merged commit 088dcf3 into dotnet:main Dec 2, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-contribution Indicates PR is created by someone from the .NET community. dotnet-csharp/svc fundamentals/subsvc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants