Conversation
Address review comments post merge
Evangelink
requested review from
Youssef1313 and
meaghanlewis
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses post-merge review comments from PR #51527, which reworked MSTest documentation to be feature-oriented. The changes improve clarity and code examples in MSTest data-driven testing documentation.
Changes:
- Reorganized the overview table to separate attributes from types/interfaces for better clarity
- Updated code examples to use modern value tuples (
IEnumerable<(int, string)>) instead of object arrays (IEnumerable<object[]>) - Simplified the unfolding strategy example by removing unused helper methods
- Clarified that the MSTEST0001 analyzer validates assembly-level parallelization declarations
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| docs/core/testing/unit-testing-mstest-writing-tests-data-driven.md | Improved table structure, modernized code examples to use tuples, and simplified unfolding example |
| docs/core/testing/unit-testing-mstest-writing-tests-controlling-execution.md | Clarified TIP about MSTEST0001 analyzer checking assembly-level parallelization intent |
Youssef1313
reviewed
Feb 16, 2026
docs/core/testing/unit-testing-mstest-writing-tests-data-driven.md
Outdated
Show resolved
Hide resolved
Youssef1313
reviewed
Feb 16, 2026
docs/core/testing/unit-testing-mstest-writing-tests-data-driven.md
Outdated
Show resolved
Hide resolved
Youssef1313
approved these changes
Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address review comments post merge on #51527
Internal previews