Use parameterized TSQL queries#52326
Merged
gewarren merged 2 commits intodotnet:mainfrom Mar 16, 2026
Merged
Conversation
BillWagner
approved these changes
Mar 16, 2026
Member
BillWagner
left a comment
BillWagner
left a comment
There was a problem hiding this comment.
This LGTM. Do we need to update the accompanying article so explain why parameterized queries are preferred?
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the TPL Dataflow “batch database” C# and Visual Basic snippets to avoid string-concatenated SQL by switching to parameterized SQL queries.
Changes:
- Replaced
string.Format-composed SQL inGetEmployeeIDwith parameterized queries. - Updated insert/select parameter creation code paths (including some formatting/field renames).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| samples/snippets/visualbasic/VS_Snippets_Misc/tpldataflow_batchdatabase/vb/dataflowbatchdatabase.vb | Parameterized GetEmployeeID query and updated insert parameter setup. |
| samples/snippets/csharp/VS_Snippets_Misc/tpldataflow_batchdatabase/cs/dataflowbatchdatabase.cs | Parameterized GetEmployeeID query; changed insert parameter setup to AddWithValue. |
Comments suppressed due to low confidence (1)
samples/snippets/visualbasic/VS_Snippets_Misc/tpldataflow_batchdatabase/vb/dataflowbatchdatabase.vb:85
- In
InsertEmployees, parameters are re-created on every loop iteration (Clear + Add). This adds overhead and can skew the batching performance demo. Consider adding the parameters once before the loop and only updating their.Valueinside the loop.
For i As Integer = 0 To employees.Length - 1
' Set parameters.
command.Parameters.Clear()
command.Parameters.Add("@lastName", SqlDbType.NVarChar).Value = employees(i).LastName
command.Parameters.Add("@firstName", SqlDbType.NVarChar).Value = employees(i).FirstName
' Execute the command.
command.ExecuteNonQuery()
Next i
You can also share your feedback on Copilot code review. Take the survey.
Comment on lines
88
to
+93
| for (int i = 0; i < employees.Length; i++) | ||
| { | ||
| // Set parameters. | ||
| command.Parameters.Clear(); | ||
| command.Parameters.Add("@lastName", employees[i].LastName); | ||
| command.Parameters.Add("@firstName", employees[i].FirstName); | ||
| command.Parameters.AddWithValue("@lastName", employees[i].LastName); | ||
| command.Parameters.AddWithValue("@firstName", employees[i].FirstName); |
Comment on lines
+142
to
+143
| command.Parameters.Add("@lastName", System.Data.SqlDbType.NVarChar).Value = lastName; | ||
| command.Parameters.Add("@firstName", System.Data.SqlDbType.NVarChar).Value = firstName; |
Comment on lines
+80
to
+81
| command.Parameters.Add("@lastName", SqlDbType.NVarChar).Value = employees(i).LastName | ||
| command.Parameters.Add("@firstName", SqlDbType.NVarChar).Value = employees(i).FirstName |
Comment on lines
+114
to
+115
| command.Parameters.Add("@lastName", lastName) | ||
| command.Parameters.Add("@firstName", firstName) |
| Imports System.Data.SqlClient | ||
| Imports System.Data.SqlServerCe | ||
| Imports System.Diagnostics | ||
| Imports System.IO |
Comment on lines
91
to
+93
| command.Parameters.Clear(); | ||
| command.Parameters.Add("@lastName", employees[i].LastName); | ||
| command.Parameters.Add("@firstName", employees[i].FirstName); | ||
| command.Parameters.AddWithValue("@lastName", employees[i].LastName); | ||
| command.Parameters.AddWithValue("@firstName", employees[i].FirstName); |
Contributor
Author
I don't think so. They were already used elsewhere on the page. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.