Skip to content

Add missing quote to example configuration#53995

Merged
gewarren merged 1 commit into
dotnet:mainfrom
Thynix:patch-2
May 21, 2026
Merged

Add missing quote to example configuration#53995
gewarren merged 1 commit into
dotnet:mainfrom
Thynix:patch-2

Conversation

@Thynix
Copy link
Copy Markdown
Contributor

@Thynix Thynix commented May 21, 2026

This string was unterminated.


Internal previews

📄 File 🔗 Preview link
docs/core/tools/dotnet-package-update.md dotnet package update

Copilot AI review requested due to automatic review settings May 21, 2026 17:45
@Thynix Thynix requested review from a team and meaghanlewis as code owners May 21, 2026 17:45
@dotnetrepoman dotnetrepoman Bot added this to the May 2026 milestone May 21, 2026
@dotnet-policy-service dotnet-policy-service Bot added dotnet-fundamentals/svc dotnet-cli/subsvc community-contribution Indicates PR is created by someone from the .NET community. labels May 21, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes an unterminated string in the dotnet package update documentation by correcting the quoting in an MSBuild Condition attribute inside an example snippet.

Changes:

  • Corrects the quoting in the <TreatWarningsAsErrors ...> example so the Condition attribute is properly terminated.

Copy link
Copy Markdown
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@gewarren gewarren enabled auto-merge (squash) May 21, 2026 18:25
@gewarren gewarren merged commit 9b5180f into dotnet:main May 21, 2026
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-contribution Indicates PR is created by someone from the .NET community. dotnet-cli/subsvc dotnet-fundamentals/svc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants