chore: Remove unused .travis.yml #8351
Conversation
| @@ -1,29 +0,0 @@ | |||
| language: csharp | |||
There was a problem hiding this comment.
@nschonni this file is referenced from the following section:
https://docs.microsoft.com/en-us/dotnet/core/tools/using-ci-with-cli#travis-ci
as the example of the .travis.yml file
There was a problem hiding this comment.
Good point, I'll see about inlining the content there as-is. Currently this just causes people forking the repo to get build failure emails when they create branches or PRs
There was a problem hiding this comment.
It's already pointing to the Travis docs, so that should be good now that they have sections on .Net Core
|
@KathleenDollard @livarcocc @dsplaisted can you guys review this PR? The original file was specific to .NET Core but has been severely outdated. Maybe we can update the travis (and the appveyor files from the previous PR) and link to their docs for extra info? |
|
If we don't have a sponsor for travis integration, we should delete the sample. I agree that it is very out of date. Stating the obvious, we should probably ensure we have good docs for DevOps integration as a higher priority. CI samples should not be in this repo, but in the samples (or other) repo. Right? |
|
closing based on the above conversation. |
|
@BillWagner the above conversation was to delete if it's not going to be maintained. Are you going to redo this PR to remove the file? |
|
@nschonni Sorry about that. I lost the context over time. Looking at it more closely, it looks like you've done exactly what @richlander recommended. Should I reopen and merge this? |
|
I think so @BillWagner. I think it would also be good to sync with @erickson-doug's team on the DevOps docs related to .NET scenarios. |
|
Resolved merge conflicts and did a small fix. I'll merge when build is green. |
5 participants
The hook no longer appears to be used and doesn't build correctly for forked repos either